Regarding point 2 I see no harm in including a button to move over
template files. Surely this is similar to having the bp-templatepack
type functionality built in?
Is there any reason why this would be a bad thing?
- Ben
On 1 September 2010 03:07, Jeffry Ghazally
> --
> You received this message because you are subscribed to the Google Groups
> "WordPress e-Commerce Plugin Development" group.
> To post to this group, send email to
> wordpress-e-c...@googlegroups.com.
> To unsubscribe from this group, send email to
> wordpress-e-commerc...@googlegroups.com.
> For more options, visit this group at
> http://groups.google.com/group/wordpress-e-commerce-plugin?hl=en.
>
Under the new "design", people should be creating a child-theme with the
customisations they require. If we move stuff into the main theme, then
their customisations will be lost if they ever update their WordPress
theme. Since themes are now part of the "auto" update mechanism in
WordPress this is probably a bad thing.
All IMHO ...
Also, if customizations only consist of small CSS changes, then what
about a user.css in the theme directory, which should never be
overwritten by the auto-update.
-
Wouter Thielen
Software Developer
Software Research & Development Div.
LINC Media, Tokyo
Nope - that's what I said - except I was explicit that they would create a
child theme ... I guess there's no reason it couldn't be a standalone
theme - as long as it isn't auto-updateable ...
Lee
Or should users be told to create a child theme and activate it then
click a button to copy the wpsc files to the child theme?
I don't want to get hung up on the button thing - I'm quite happy not
to have it as I'm capable of doing all this myself - but I'm wondering
if it will be more friendly for users? Is it possible to detect if the
current active theme is a child theme and if so show a copy files
button if a child theme is active, otherwise show instructions to
create a child theme?
- Ben
Personally, I think they should manually copy the files that they want to
override into their child theme. There's no point copying all of the files
(Under the new scheme it's unnecessary), and in fact doing so, may mean
that they miss out on updates to files that they haven't customised.
Regards
Lee
Right you are. Makes sense.
In which case I'm going down the no copy button needed (maybe just a
link and some good documentation on getshopped how to create a child
theme and add templates)
- Ben
Thank you,
Jeremy Smith email: jer...@dnawebagency.com
web:
www.dnawebagency.com
tel:
541.690.8628
office:
541.582.8154 ext. 1003
So - even if we allow a "copy" button - without FTP knowledge - they can't
make any customisations anyway ...
--
I beg to differ. As per my previous reply to Ben. If we push *all* of the
WPEC files out into their WP theme directory, then that user will not see
*any* updates / fixes that we make in the plugin in the future - their
copies will be preferred, and used by WordPress.
If we encourage the user to take across *only* the files they need and
want to change then they will still get all fixes for files that they
aren't overriding - they only miss out on fixes to files they've
customised, and that's unavoidable.
Lee
--
OK - so this I still disagree :)
There's no point copying all of the WPEC theme files (I had 6 in my
document - the number could be higher once we theme-ise other widgets, and
other pages like my account etc.) into the user's theme - as I said this
would cause the user to miss out on fixes / updates unnecessarily.
They should only have files in their theme folder that they (or the theme
author) wanted to customise.
So - using my doc as an example, the theme author distributes the
FunkyWordPressTheme theme, with 2 WPEC templates in. These are used by
WordPress to display the category, and single product views. All other
WPEC stuff would be taken from the plugin itself. If the plugin is
updated, then the user will get the advantage of all theme-updates apart
from those two files.
The user then wants to customise the single product view, so he creates a
child theme MyFunkyWordPressTheme, containing just the single product page
template. So, at this point, the single product view comes from the user's
customised theme, the category view comes from the FunkyWordPressTheme
theme, and all other pages use the files provided by the plugin.
If the user installs an updated version of the FunkyWordPressTheme then he
will get the benefit of any improvements the theme author has made to the
category view - although not the single product view unless he ports them
across to his child theme.
Make sense?
Regards
Lee
Best
Jeff
Less screaming more coding
www.screamingcodemonkey.com
Lee I'm trying to please every one here so bear with me, what about a checkbox list of files to port to their selected theme?
Thank you,
Jeremy Smith email: jer...@dnawebagency.com
web:
www.dnawebagency.com
tel:
541.690.8628
office:
541.582.8154 ext. 1003
I can't really object to that [As long as the default is all un-checked] :)
I think it's work I don't think you *need* to do since anyone who is going
to do customisations need to know FTP to get their changes up there. But
if you want to do it to make things more user-friendly then that's a good
compromise...
Also note, you can edit your theme files through the theme editor in
the admin without knowing FTP ;)
- Ben
Maybe I'm being paranoid. But given the extent of the changes (3.8 vs 3.7) we're already going to be blowing peoples minds. Like everybody else on this list I just want to make sure we hit the right compromise of having something that nurtures the less technical inclined people through the process, and at the same time, is done in a modern WordPress friendly way.
I really appreciate all the thought and input that has gone into this!
Kapai!!!
http://en.wikipedia.org/wiki/M%C4%81ori_influence_on_New_Zealand_English#Other_terms
Ciao,
Dan
On 2/09/10 10:03 AM, Jeffry Ghazally wrote:
> LoL, very true good ol non syntax highlighted theme editor...
> Yea I was thinking Theme Pack, but Dan thinks this is something most users will want, therefore core it goes :)
>
> On 2/09/2010, at 9:29 AM, Ben Huson wrote:
>
>> If the copy button is going to have to offer the option of which
>> templates to copy, maybe this functionality is better suited to a WPEC
>> Template Pack type plugin afterall?
>>
>> Also note, you can edit your theme files through the theme editor in
>> the admin without knowing FTP ;)
>>
>> - Ben
>>
>> On 1 September 2010 21:31, Lee Willis <l...@leewillis.co.uk> wrote:
>>>> Lee I'm trying to please every one here so bear with me, what about a
>>>> checkbox list of files to port to their selected theme?
>>>
>>> I can't really object to that [As long as the default is all un-checked] :)