Account Options

  1. Sign in
The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Google Groups Home
« Groups Home
blagh patch
There are currently too many topics in this group that display first. To make this topic appear first, remove this option from another topic.
There was an error processing your request. Please try again.
flag
  4 messages - Collapse all  -  Translate all to Translated (View all originals)
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
 
From:
To:
Cc:
Followup To:
Add Cc | Add Followup-to | Edit Subject
Subject:
Validation:
For verification purposes please type the characters you see in the picture below or the numbers you hear by clicking the accessibility icon. Listen and type the numbers you hear
 
yy  
View profile  
 More options Nov 10 2009, 4:47 pm
From: yy <yiyu....@gmail.com>
Date: Tue, 10 Nov 2009 22:47:03 +0100
Local: Tues, Nov 10 2009 4:47 pm
Subject: blagh patch

There is a (known now) bug in blagh: if link references are repeated
in different posts you won't get the links you expect in the main
page. The reason is all the posts in markdown format are concatenated
before being transformed to html. This patch tries to solve this
problem (and some problems of my previous fix, as discussed on irc). I
think it also makes a better use of fltr_cache. If the patch is finaly
applied feel free to rename the cat_post_list function to anything
better, and change the sed command to add the terminating slash to
whichever idiom is used in the rest of werc code.

--
- yiyus || JGL . 4l77.com

  blagh.patch
1K Download

 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Uriel  
View profile  
 More options Nov 10 2009, 5:09 pm
From: Uriel <urie...@gmail.com>
Date: Tue, 10 Nov 2009 23:09:09 +0100
Local: Tues, Nov 10 2009 5:09 pm
Subject: Re: blagh patch

On Tue, Nov 10, 2009 at 10:47 PM, yy <yiyu....@gmail.com> wrote:
> There is a (known now) bug in blagh: if link references are repeated
> in different posts you won't get the links you expect in the main
> page. The reason is all the posts in markdown format are concatenated
> before being transformed to html. This patch tries to solve this
> problem (and some problems of my previous fix, as discussed on irc).

Great! Just for everyone not aware: the irc channel is now #cat-v in
irc.freenode.org.

>  I think it also makes a better use of fltr_cache. If the patch is finaly
> applied feel free to rename the cat_post_list function to anything
> better, and change the sed command to add the terminating slash to
> whichever idiom is used in the rest of werc code.

This solves some of the issues, but as I noted in irc: I still think
it should not touch the generated html and instead manipulate the
markdown, and it breaks the proper chronological sorting of dir
"aggregations".

But it is going in the right direction...

Thanks!

uriel


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
yy  
View profile  
 More options Nov 10 2009, 6:06 pm
From: yy <yiyu....@gmail.com>
Date: Wed, 11 Nov 2009 00:06:09 +0100
Local: Tues, Nov 10 2009 6:06 pm
Subject: Re: blagh patch

2009/11/10 Uriel <urie...@gmail.com>:

> This solves some of the issues, but as I noted in irc: I still think
> it should not touch the generated html and instead manipulate the
> markdown, and it breaks the proper chronological sorting of dir
> "aggregations".

this version of blagh.patch should work, it is a bit simpler. you want
blagh.donottouchthehtml.patch, but if you use that you will finish
with two almost identical html outputs in the cache for every file

--
- yiyus || JGL . 4l77.com

  blagh.patch
1K Download

  blagh.donottouchthehtml.patch
1K Download

 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Uriel  
View profile  
 More options Nov 10 2009, 6:32 pm
From: Uriel <urie...@gmail.com>
Date: Wed, 11 Nov 2009 00:32:42 +0100
Local: Tues, Nov 10 2009 6:32 pm
Subject: Re: blagh patch

On Wed, Nov 11, 2009 at 12:06 AM, yy <yiyu....@gmail.com> wrote:
> 2009/11/10 Uriel <urie...@gmail.com>:
>> This solves some of the issues, but as I noted in irc: I still think
>> it should not touch the generated html and instead manipulate the
>> markdown, and it breaks the proper chronological sorting of dir
>> "aggregations".

> this version of blagh.patch should work, it is a bit simpler. you want
> blagh.donottouchthehtml.patch, but if you use that you will finish
> with two almost identical html outputs in the cache for every file

Thanks, but I'm a bit mystified as to what the

 | fltr_cache cat

does, as far as I can see it doesn't really do anything useful, in
which case the patch is the obvious patch, but which I had not
implemented as I wanted to avoid calling fltr_cache/$formatter for
every single post.

Anyway, maybe we should implement the obvious fix, but given that it
is not too critical (references are fortunately rarely used, and I was
considering just forbidding their use altogether), and I was hopping
for something that would actually cache the work done inside the loop,
to do that factoring things out into an external function is the way
to go, but fltr_cache might need to be extended to allow taking
multiple files and/or dirs instead of just one.

Thanks again for the effort though :)

uriel


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
End of messages
« Back to Discussions « Newer topic     Older topic »