watchdog - Bugs and code review

[Laurent LAPORTE]

Hi,

I'm working on a "FTP watchdog" service. I inspire myself of the watchdog project. During my work I foud some potential bugs and I made a code review. Here is a summary:

• Anomalies and potential bugs
  
• Don’t forget to close files
• Wrong “Compares two directory snapshots” algorithm
• Code review
  
• Indent the source code
• Dictionaries’ iterations should be changed
• Avoid function callback in default parameters
• Remove dead code
• Don’t abuse of decorators
• Don’t abuse of properties

The details are in the attached "review.rst" file (it use reStructureText format).

I focus my analyse on the master version found at https://github.com/gorakhargosh/watchdog.

I hope it helps.

------- Laurent.

[Christian Tismer]

Hi Laurent,

Interesting, good review!

I would like to ask if we can talk about your stuff. Recently I added the ability to 

monitor network drives from virtual servers, but I retracted my pull request.

You can reach me at tismer(at)stackless.com

cheers - chris