Re: Patch 7.3.386

[raf]

hi,

i just upgraded my vim and applied this patch but it didn't affect
the failing of test83 for me. this patch assumes that the cause of
the failure was iconv not supporting cp932 but iconv on macosx-10.6.8
and ubuntu-11.04 do support cp932. i checked that at the time when
Yukihiro Nakadaira suggested it.

the font i use doesn't display the wide cp932 characters well
(just dotted boxes) but the conversion itself seems to work.

i've attached the test83 files in case they help.

cheers,
raf

[Yukihiro Nakadaira]

I have no idea why it fails.
Could you run test case 2 by hand?

$ cd vim/src/testdir
$ cat >Xtags2.txt <<EOF
> text for tags2
> ＡＢＣ
> EOF
$ ../vim -u NONE
:set tags=test83-tags2
:tag /.ＢＣ

--
Yukihiro Nakadaira - yukihiro....@gmail.com

[raf]

Yukihiro Nakadaira wrote:

> On Mon, Feb 13, 2012 at 10:19 AM, raf <r...@raf.org> wrote:
> > i just upgraded my vim and applied this patch but it didn't affect
> > the failing of test83 for me. this patch assumes that the cause of
> > the failure was iconv not supporting cp932 but iconv on macosx-10.6.8
> > and ubuntu-11.04 do support cp932. i checked that at the time when
> > Yukihiro Nakadaira suggested it.
>

> I have no idea why it fails.
> Could you run test case 2 by hand?
>
> $ cd vim/src/testdir
> $ cat >Xtags2.txt <<EOF
> > text for tags2
> > ＡＢＣ
> > EOF
> $ ../vim -u NONE
> :set tags=test83-tags2
> :tag /.ＢＣ
> --
> Yukihiro Nakadaira - yukihiro....@gmail.com

vim says: E426: tag not found: .ＢＣ

[Yukihiro Nakadaira]

Thank you.

Is 'encoding' utf-8?
If not, retry ":tag /.ＢＣ" command after ":set enc=utf-8".

Perhaps it is iconv problem. If so, latin1 should work because Vim
perform utf8-latin1 conversion itself. I attached test file for latin1.
Try the following command.

:set enc=utf-8
:set tags=latin1.tags
:tag /.ÂÃ

[raf]

Yukihiro Nakadaira wrote:

> On Tue, Feb 21, 2012 at 7:10 PM, raf <r...@raf.org> wrote:
> > Yukihiro Nakadaira wrote:
> >
> >> On Mon, Feb 13, 2012 at 10:19 AM, raf <r...@raf.org> wrote:
> >> > i just upgraded my vim and applied this patch but it didn't affect
> >> > the failing of test83 for me. this patch assumes that the cause of
> >> > the failure was iconv not supporting cp932 but iconv on macosx-10.6.8
> >> > and ubuntu-11.04 do support cp932. i checked that at the time when
> >> > Yukihiro Nakadaira suggested it.
> >>
> >> I have no idea why it fails.
> >> Could you run test case 2 by hand?
> >>
> >> $ cd vim/src/testdir
> >> $ cat >Xtags2.txt <<EOF
> >> > text for tags2
> >> > ＡＢＣ
> >> > EOF
> >> $ ../vim -u NONE
> >> :set tags=test83-tags2
> >> :tag /.ＢＣ
> >> --
> >> Yukihiro Nakadaira - yukihiro....@gmail.com
> >
> > vim says: E426: tag not found: .ＢＣ
>
> Thank you.
>
> Is 'encoding' utf-8?

yes, it is.

> If not, retry ":tag /.ＢＣ" command after ":set enc=utf-8".

i tried this anyway and it still didn't work.

> Perhaps it is iconv problem. If so, latin1 should work because Vim
> perform utf8-latin1 conversion itself. I attached test file for latin1.
> Try the following command.
>
> :set enc=utf-8
> :set tags=latin1.tags
> :tag /.ÂÃ
> --
> Yukihiro Nakadaira - yukihiro....@gmail.com

that did work. it took me to line 3 of latin1.txt
(which is encoded in utf-8).

the libiconv that this version of vim (X11-Motif) is using is the
one from MacPorts (/opt/local/lib/libiconv.2.dylib (v1.14)).

the libiconv that the system-supplied version of vim (/usr/bin/vim)
is using is the system-suplied one (/usr/lib/libiconv.2.dylib).

if i repeat the test using the system-supplied vim (/usr/bin/vim)
the behaviour is different:

vim says: E434: Can't find tag pattern
and then takes me to line 1 of Xtags2.txt
(but not to line 2 where the tagged text is).

however, the MacPorts non-gui version of vim
(/Applications/MacPorts/MacVim.app/Contents/MacOS/Vim)
is using the MacPorts version of libiconv but it is
exhibiting the same behaviour as the system-supplied
version of vim described above.

i can't tell what version of libiconv is being used by
the MacPorts version of gui vim (it doesn't show up in otool -l)
(/Applications/MacPorts/MacVim.app/Contents/MacOS/MacVim)
but it's behaviour is also the same as the system-supplied
version of vim.

so the mapping between libiconv and behaviour isn't consistent.

i am seeing the same behaviour on a linux system (the
system-supplied vim on linux behaves like the system-supplied
vim on macosx and my compiled vim on linux behaves the same
as my compiled vim on macosx) but there is no libiconv at
all on the linux host (it has /usr/bin/iconv).

in summary:

behaviour 1 = E426: tag not found: .ＢＣ
behaviour 2 = E434: Can't find tag pattern

macosx ubuntu
my vim 1 1
system vim 2 2
macports Vim 2
macports MacVim 2

cheers,
raf

p.s. i don't think it's relevant but when running vim in xterm,
the characters ＡＢＣ are displayed correctly when viewing/editing
a file and when pasting them in vim's command line to do the
:tag command but they are not displayed correctly in the
tag-not-found error message. there, they just look like dotted
boxes. i figure that can't be a font problem. actually, maybe
it is. the error message is in bold. maybe the bold version
of that fon't doesn't have those characters but the regular
version does. no, that's not it. if i change the xterm font
to be the bold version, the same behaviour happens.

[Yukihiro Nakadaira]

On Wed, Feb 22, 2012 at 8:43 AM, raf <r...@raf.org> wrote:
> behaviour 1 = E426: tag not found: .ＢＣ
> behaviour 2 = E434: Can't find tag pattern
>
>                 macosx      ubuntu
> my vim           1           1
> system vim       2           2
> macports Vim     2
> macports MacVim  2

I think that "E434: Can't find tag pattern" means that the running Vim
is old and doesn't contain patch 7.3.386.
On my ubuntu 11.10 pc, /usr/bin/vim is 7.3.154 and result is same.
"/usr/bin/vim -u unix.vim -s dotest.in test83.in" hangs.

"E426: tag not found: .ＢＣ" seems iconv doesn't work. But in that
case, test83 should successfully finish without running test case.
Hmm...

Could you show me the output of :version command on ubuntu? And what is
your configure command?

[raf]

Yukihiro Nakadaira wrote:

> On Wed, Feb 22, 2012 at 8:43 AM, raf <r...@raf.org> wrote:
> > behaviour 1 = E426: tag not found: .ＢＣ
> > behaviour 2 = E434: Can't find tag pattern
> >
> >                 macosx      ubuntu
> > my vim           1           1
> > system vim       2           2
> > macports Vim     2
> > macports MacVim  2
>
> I think that "E434: Can't find tag pattern" means that the running Vim
> is old and doesn't contain patch 7.3.386.
> On my ubuntu 11.10 pc, /usr/bin/vim is 7.3.154 and result is same.
> "/usr/bin/vim -u unix.vim -s dotest.in test83.in" hangs.
>
> "E426: tag not found: .ＢＣ" seems iconv doesn't work. But in that
> case, test83 should successfully finish without running test case.
> Hmm...

iconv works. i tested that with:

:set encoding=utf-8
:echo iconv("\x82\x60", "cp932", "utf-8") == "\uff21"

although i just realised that my system vim on ubuntu (which i don't use)
was the vim-tiny package that didn't like that :echo iconv command so i've
replaced it with the vim package instead which does. it still produces
behaviour 2.

> Could you show me the output of :version command on ubuntu? And what is
> your configure command?
> --
> Yukihiro Nakadaira - yukihiro....@gmail.com

ubuntu configure command:
-------------------------
./configure \
--with-x \
--enable-gui=motif \
--enable-multibyte

ubuntu version:
---------------
VIM - Vi IMproved 7.3 (2010 Aug 15, compiled Feb 13 2012 12:09:56)
Included patches: 1-443
Compiled by r...@eccles.raf.org
Normal version with X11-Motif GUI. Features included (+) or not (-):
-arabic +autocmd +balloon_eval +browse +builtin_terms +byte_offset +cindent +clientserver +clipboard +cmdline_compl
+cmdline_hist +cmdline_info +comments -conceal +cryptv -cscope +cursorbind +cursorshape +dialog_con_gui +diff +digraphs
-dnd -ebcdic -emacs_tags +eval +ex_extra +extra_search -farsi +file_in_path +find_in_path +float +folding -footer
+fork() +gettext -hangul_input +iconv +insert_expand +jumplist -keymap -langmap +libcall +linebreak +lispindent
+listcmds +localmap -lua +menu +mksession +modify_fname +mouse +mouseshape -mouse_dec -mouse_gpm -mouse_jsbterm
-mouse_netterm -mouse_sysmouse +mouse_xterm -mouse_urxvt +multi_byte +multi_lang -mzscheme +netbeans_intg +path_extra
-perl +persistent_undo +postscript +printer -profile -python -python3 +quickfix +reltime -rightleft -ruby +scrollbind
+signs +smartindent -sniff +startuptime +statusline -sun_workshop +syntax +tag_binary +tag_old_static -tag_any_white
-tcl +terminfo +termresponse +textobjects +title +toolbar +user_commands +vertsplit +virtualedit +visual +visualextra
+viminfo +vreplace +wildignore +wildmenu +windows +writebackup +X11 +xfontset +xim +xsmp_interact +xterm_clipboard
-xterm_save
system vimrc file: "$VIM/vimrc"
user vimrc file: "$HOME/.vimrc"
user exrc file: "$HOME/.exrc"
system gvimrc file: "$VIM/gvimrc"
user gvimrc file: "$HOME/.gvimrc"
system menu file: "$VIMRUNTIME/menu.vim"
fall-back for $VIM: "/usr/local/share/vim"
Compilation: gcc -c -I. -Iproto -DHAVE_CONFIG_H -DFEAT_GUI_MOTIF -DFUNCPROTO=15 -DNARROWPROTO -g -O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1
Linking: gcc -L/usr/local/lib -Wl,--as-needed -o vim -lXp -lXext -lXm -lXt -lSM -lICE -lXpm -lXt -lX11 -lXdmcp -lSM -lICE -ldl -lm -lncurses -lnsl

macosx configure command:
-------------------------
./configure \
--disable-darwin \
--with-x \
--enable-gui=motif \
--enable-multibyte \
--with-mac-arch=current \
--with-features=huge \
--disable-acl \
"$@"

macosx version:
---------------
VIM - Vi IMproved 7.3 (2010 Aug 15, compiled Feb 22 2012 11:51:57)
Included patches: 1-443
Compiled by r...@neddy.advancepayroll.com.au
Huge version with X11-Motif GUI. Features included (+) or not (-):
+arabic +autocmd +balloon_eval +browse ++builtin_terms +byte_offset +cindent +clientserver +clipboard +cmdline_compl
+cmdline_hist +cmdline_info +comments +conceal +cryptv +cscope +cursorbind +cursorshape +dialog_con_gui +diff +digraphs
-dnd -ebcdic +emacs_tags +eval +ex_extra +extra_search +farsi +file_in_path +find_in_path +float +folding -footer
+fork() -gettext -hangul_input +iconv +insert_expand +jumplist +keymap +langmap +libcall +linebreak +lispindent
+listcmds +localmap -lua +menu +mksession +modify_fname +mouse +mouseshape +mouse_dec -mouse_gpm -mouse_jsbterm
+mouse_netterm -mouse_sysmouse +mouse_xterm +mouse_urxvt +multi_byte +multi_lang -mzscheme +netbeans_intg +path_extra
-perl +persistent_undo +postscript +printer +profile -python -python3 +quickfix +reltime +rightleft -ruby +scrollbind
+signs +smartindent -sniff +startuptime +statusline -sun_workshop +syntax +tag_binary +tag_old_static -tag_any_white
-tcl +terminfo +termresponse +textobjects +title +toolbar +user_commands +vertsplit +virtualedit +visual +visualextra
+viminfo +vreplace +wildignore +wildmenu +windows +writebackup +X11 +xfontset +xim +xsmp_interact +xterm_clipboard
-xterm_save
system vimrc file: "$VIM/vimrc"
user vimrc file: "$HOME/.vimrc"
user exrc file: "$HOME/.exrc"
system gvimrc file: "$VIM/gvimrc"
user gvimrc file: "$HOME/.gvimrc"
system menu file: "$VIMRUNTIME/menu.vim"
fall-back for $VIM: "/usr/local/share/vim"
Compilation: gcc -c -I. -Iproto -DHAVE_CONFIG_H -DFEAT_GUI_MOTIF -I/opt/local/include -g -O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1 -I/opt/local/include
Linking: gcc -L/opt/local/lib -L/opt/local/lib -R/opt/local/lib -L/usr/local/lib -o vim -lXmu -lXext -lXm -lXpm -lXt -lX11 -lSM -lICE -lm -lncurses -liconv

[Yukihiro Nakadaira]

I clean installed ubuntu-11.04-{server,desktop} and ran test as
following. But it didn't fail.

$ sudo apt-get build-dep vim
$ sudo apt-get install libmotif-dev mercurial
$ hg clone https://vim.googlecode.com/hg/ vim
$ cd vim
$ ./configure --with-x --enable-gui=motif --enable-multibyte
$ make test