Issue 84 in vim: [PATCH] Missing "the" in documentation.

45 views
Skip to first unread message

v...@googlecode.com

unread,
Oct 12, 2012, 3:57:31 PM10/12/12
to vim...@vim.org
Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 84 by shlo...@iglu.org.il: [PATCH] Missing "the" in documentation.
http://code.google.com/p/vim/issues/detail?id=84

What steps will reproduce the problem?
1. usr_41.txt reads "Sometimes you want to make a change and go back to
where cursor was."

It should read "where the cursor was".

What version of the product are you using? On what operating system?

hg HEAD.

Attached is a patch to correct the problem.

Attachments:
hg.diff 557 bytes

v...@googlecode.com

unread,
Oct 12, 2012, 6:32:16 PM10/12/12
to vim...@vim.org
Updates:
Status: Fixed

Comment #1 on issue 84 by brammool...@gmail.com: [PATCH] Missing "the" in
documentation.
http://code.google.com/p/vim/issues/detail?id=84

(No comment was entered for this change.)

v...@googlecode.com

unread,
Oct 18, 2012, 10:26:47 AM10/18/12
to vim...@vim.org

Comment #2 on issue 84 by shl...@gmail.com: [PATCH] Missing "the" in
documentation.
http://code.google.com/p/vim/issues/detail?id=84

This issue is still present in «hg clone https://code.google.com/p/vim/» in
revision «changeset: 3872:1001f417a37182832612cde6d11fb321907e49ea». Why
was it closed as fixed without the patch being applied? Either it should be
marked as invalid (which I believe it is not), or the patch should be
applied and pushed before it is closed.

Frustrated,

-- Shlomi Fish


Christian Brabandt

unread,
Oct 18, 2012, 10:44:11 AM10/18/12
to vim...@googlegroups.com
(Sorry, currently have no login for googlecode.com, so only replying on
the list, hope you also read it):
I think, Bram fixed it locally in his code tree, but did not push yet
an update to the main server on googlecode.com.
If you browse the commits (http://code.google.com/p/vim/source/list),
you'll see, that Bram every once in a while pushes runtime file update
and the last runtime push was before you submitted issue #84

I am pretty sure your fix, will be pushed eventually to the main
repository, whenever Bram has aggregated enough changes.

regards,
Christian

v...@googlecode.com

unread,
Oct 18, 2012, 2:21:15 PM10/18/12
to vim...@vim.org

Comment #3 on issue 84 by brammool...@gmail.com: [PATCH] Missing "the" in
documentation.
http://code.google.com/p/vim/issues/detail?id=84

Runtime file changes go out at irregular intervals. I mark items as fixed
when I updated the master copy (that's on my harddisk, nobody else sees it
yet).

v...@googlecode.com

unread,
Oct 21, 2012, 7:40:52 AM10/21/12
to vim...@vim.org

Comment #4 on issue 84 by shl...@gmail.com: [PATCH] Missing "the" in
documentation.
http://code.google.com/p/vim/issues/detail?id=84

Bram: OK, I see. Seems like there was a communication problem. Maybe
include a standard blurb explaining all this when closing this bug in the
future (and I don't understand why you can't use Mercurial for individual
commits to the runtime files as well).

v...@googlecode.com

unread,
Oct 21, 2012, 1:49:53 PM10/21/12
to vim...@vim.org

Comment #5 on issue 84 by antoine....@gmail.com: [PATCH] Missing "the" in
documentation.
http://code.google.com/p/vim/issues/detail?id=84

In reply to comment 4:
Bram does use Mercurial for individual runtime files, only he uses a
private Vim repository on his hard disk. From time to time (and for
instance between patches 7.3.702 and 7.3.703) he pushes them to the public
repository from which everyone can pull them, thus bringing all doc/* files
in sync between private and public repositories. Otherwise it may happen
that updated runtime files are published "out of turn" (for instance
menu.vim at patch 7.3.696, and doc/eval.txt at patch 7.3.694 documenting an
update to the eval.c source file in the same patch) but it is the exception
rather than the rule.

v...@googlecode.com

unread,
Oct 21, 2012, 1:52:05 PM10/21/12
to vim...@vim.org

Comment #6 on issue 84 by antoine....@gmail.com: [PATCH] Missing "the" in
documentation.
http://code.google.com/p/vim/issues/detail?id=84

In reply to comment 4:
Bram does use Mercurial for individual runtime files, only he uses a
private Vim repository on his hard disk. From time to time (and for
instance between patches 7.3.702 and 7.3.703) he pushes them to the public
repository from which everyone can pull them, thus bringing all runtime
files in sync between private and public repositories. Otherwise it may
happen that updated runtime files are published "out of turn" (for instance
runtime/menu.vim at patch 7.3.696, and runtime/doc/eval.txt at patch
7.3.694 documenting an update to the src/eval.c file in the same patch) but
Reply all
Reply to author
Forward
0 new messages