Account Options

  1. Sign in
The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Google Groups Home
« Groups Home
vim_dev
Home
+ new post
About this group
Join this group
Message from discussion Redraws slow down proportionately to the number of open tabs in gvim/win32
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
 
From:
To:
Cc:
Followup To:
Add Cc | Add Followup-to | Edit Subject
Subject:
Validation:
For verification purposes please type the characters you see in the picture below or the numbers you hear by clicking the accessibility icon. Listen and type the numbers you hear
 
Ken Takata  
View profile  
 More options Oct 23 2012, 6:44 pm
From: Ken Takata <ken...@csc.jp>
Date: Tue, 23 Oct 2012 15:44:55 -0700 (PDT)
Local: Tues, Oct 23 2012 6:44 pm
Subject: Re: [PATCH] Redraws slow down proportionately to the number of open tabs in gvim/win32
Print | View thread | Show original | Report this message | Find messages by this author

Hi Arseny,

2012/10/4 Thu 15:13:56 UTC+9 Arseny Kapoulkine:

> gui_mch_update_tabline in Windows gvim is quadratic in the number of tabs. This happens because the entire control is redrawn after every InsertItem/SetItem/DeleteItem message. The delay starts to get *really* noticeable at 60 open tabs or so (Windows 7).

> Note that disabling redraws during the update is not enough - the code used GetTabItemRect to check if the item is present; however, this forces the tab control to recompute the layout after every change, which still results in quadratic behavior.

> The attached patch fixes the issue.

After applying your patch, the variable rc is no more used in
the function gui_mch_update_tabline().

diff --git a/src/gui_w48.c b/src/gui_w48.c
--- a/src/gui_w48.c
+++ b/src/gui_w48.c
@@ -2446,7 +2446,6 @@
     TCITEM     tie;
     int                nr = 0;
     int                curtabidx = 0;
-    RECT       rc;
 #ifdef FEAT_MBYTE
     static int use_unicode = FALSE;
     int                uu;

Thanks,
Ken Takata


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Create a group - Google Groups - Google Home - Terms of Service - Privacy Policy
©2013 Google