Account Options

  1. Sign in
The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Google Groups Home
« Groups Home
Patch 7.3.604
There are currently too many topics in this group that display first. To make this topic appear first, remove this option from another topic.
There was an error processing your request. Please try again.
flag
  2 messages - Collapse all  -  Translate all to Translated (View all originals)
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
 
From:
To:
Cc:
Followup To:
Add Cc | Add Followup-to | Edit Subject
Subject:
Validation:
For verification purposes please type the characters you see in the picture below or the numbers you hear by clicking the accessibility icon. Listen and type the numbers you hear
 
Bram Moolenaar  
View profile  
 More options Jul 16 2012, 1:27 pm
From: Bram Moolenaar <B...@Moolenaar.net>
Date: Mon, 16 Jul 2012 19:27:43 +0200
Local: Mon, Jul 16 2012 1:27 pm
Subject: Patch 7.3.604

Patch 7.3.604
Problem:    inputdialog() doesn't use the cancel argument in the console.
            (David Fishburn)
Solution:   Use the third argument. (Christian Brabant)
Files:      src/eval.c

*** ../vim-7.3.603/src/eval.c   2012-07-16 17:31:48.000000000 +0200
--- src/eval.c  2012-07-16 19:20:47.000000000 +0200
***************
*** 12940,12945 ****
--- 12940,12946 ----
                int     xp_namelen;
                long    argt;

+               /* input() with a third argument: completion */
                rettv->vval.v_string = NULL;

                xp_name = get_tv_string_buf_chk(&argvars[2], buf);
***************
*** 12958,12963 ****
--- 12959,12969 ----
            rettv->vval.v_string =
                getcmdline_prompt(inputsecret_flag ? NUL : '@', p, echo_attr,
                                  xp_type, xp_arg);
+       if (rettv->vval.v_string == NULL
+               && argvars[1].v_type != VAR_UNKNOWN
+               && argvars[2].v_type != VAR_UNKNOWN)
+           rettv->vval.v_string = vim_strsave(get_tv_string_buf(
+                                                          &argvars[2], buf));

        vim_free(xp_arg);

*** ../vim-7.3.603/src/version.c        2012-07-16 17:31:48.000000000 +0200
--- src/version.c       2012-07-16 19:23:11.000000000 +0200
***************
*** 716,717 ****
--- 716,719 ----
  {   /* Add new patch number below this line */
+ /**/
+     604,
  /**/

--
hundred-and-one symptoms of being an internet addict:
135. You cut classes or miss work so you can stay home and browse the web.

 /// Bram Moolenaar -- B...@Moolenaar.net -- http://www.Moolenaar.net   \\\
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\  an exciting new programming language -- http://www.Zimbu.org        ///
 \\\            help me help AIDS victims -- http://ICCF-Holland.org    ///


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
David Fishburn  
View profile  
 More options Jul 16 2012, 3:36 pm
From: David Fishburn <dfishburn....@gmail.com>
Date: Mon, 16 Jul 2012 15:36:45 -0400
Local: Mon, Jul 16 2012 3:36 pm
Subject: Re: Patch 7.3.604
On 16/07/2012 1:27 PM, Bram Moolenaar wrote:

> Patch 7.3.604
> Problem:    inputdialog() doesn't use the cancel argument in the console.
>        (David Fishburn)
> Solution:   Use the third argument. (Christian Brabant)
> Files:         src/eval.c

I can confirm when hitting Escape on the echo inputdialog() it now
reports -1.

Hitting CTRL-C shows nothing, but I suspect that is the desired
behaviour, the echo is cancelled as well as the inputdialog().

Thanks for the fix.
Dave


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
End of messages
« Back to Discussions « Newer topic     Older topic »