Bug: vim --help prints error message at the end of help

[Ivan Krasilnikov]

vim --help after patch 7.3.315 in gtk-enabled vim started to print the
following message at the end of help:

E852: The child process failed to start the GUI
(or "E233: cannot open display" if launched not in X11)
Press ENTER or type command to continue

And after pressing Enter, it doesn't quit but drops me into editor window.

[Ivan Krasilnikov]

Proposed patch - setting gui.dofork to FALSE at the end of usage(),
where it says "Gnome gives extra messages for --help if we continue",
seems to solve this problem,

[Bram Moolenaar]

Ivan Krasilnikov wrote:

Do you mean this:

*** ../vim-7.3.363/src/main.c 2011-10-04 16:43:49.000000000 +0200
--- src/main.c 2011-12-01 20:14:40.000000000 +0100
***************
*** 3294,3300 ****
--- 3294,3303 ----
#ifdef FEAT_GUI_GNOME
/* Gnome gives extra messages for --help if we continue, but not for -h. */
if (gui.starting)
+ {
mch_msg("\n");
+ gui.dofork = FALSE;
+ }
else
#endif
mch_exit(0);

--
Your fault: core dumped

/// Bram Moolenaar -- Br...@Moolenaar.net -- http://www.Moolenaar.net \\\
/// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\ an exciting new programming language -- http://www.Zimbu.org ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///

[Ivan Krasilnikov]

On Thu, Dec 1, 2011 at 20:59, Bram Moolenaar <Br...@moolenaar.net> wrote:
> Do you mean this:
>
> *** ../vim-7.3.363/src/main.c   2011-10-04 16:43:49.000000000 +0200
> --- src/main.c  2011-12-01 20:14:40.000000000 +0100
> ***************
> *** 3294,3300 ****
> --- 3294,3303 ----
>  #ifdef FEAT_GUI_GNOME
>      /* Gnome gives extra messages for --help if we continue, but not for -h. */
>      if (gui.starting)
> +     {
>        mch_msg("\n");
> +       gui.dofork = FALSE;
> +     }
>      else
>  #endif
>        mch_exit(0);
>

Yes.