make release.check fails as missing cpplint.py

173 views
Skip to first unread message

Joe Millenbach

unread,
Oct 24, 2012, 5:05:09 PM10/24/12
to v8-users
I'm trying to follow the directions on the build page to both build
and test my shells. But I get the below error after the builds
complete...

...
cctest/test-platform-linux.o
LINK(target) /home/jmillenbach/perf/v8/out/ia32.release/cctest
TOUCH /home/jmillenbach/perf/v8/out/ia32.release/obj.target/build/
All.stamp
make[1]: Leaving directory `/home/jmillenbach/perf/v8/out'
>>> running presubmit tests
Running C++ lint check...
Error running cpplint.py. Please make sure you have depot_tools in
your $PATH. Lint check skipped.
...

Which is repeated a number of times. Is there a package I need to
install? I did a search and nothing obvious popped up in Google. I'm
using Ubuntu 12.04 x64. And is there a reason this isn't in the
dependencies I already downloaded at the beginning of the build
process?

Thanks for your time,
Joe

Jérémy Lal

unread,
Oct 24, 2012, 5:08:27 PM10/24/12
to v8-u...@googlegroups.com
That shouldn't stop the build ?

If it does, try fiddling with
TESTFLAGS="--no-presubmit"

J�r�my.

Vyacheslav Egorov

unread,
Oct 24, 2012, 5:59:30 PM10/24/12
to v8-u...@googlegroups.com
> Please make sure you have depot_tools in your $PATH.

http://dev.chromium.org/developers/how-tos/install-depot-tools

--
Vyacheslav Egorov
> --
> v8-users mailing list
> v8-u...@googlegroups.com
> http://groups.google.com/group/v8-users

Joe Millenbach

unread,
Oct 25, 2012, 3:32:34 PM10/25/12
to v8-u...@googlegroups.com
I didn't see mention of this on the V8 build page.  Thanks!  The error message made me think I needed something like this, but I didn't know where to start looking.

- Joe Millenbach

Joe Millenbach

unread,
Oct 25, 2012, 3:34:51 PM10/25/12
to v8-u...@googlegroups.com, hol...@gmail.com
It appeared to stop the check process at least.  It gave a number of errors, but it only tested the ia32 when I was doing a "make release.check" build.  Thanks for the tip on how to skip it, but I'll probably just install the depot tools as Vyacheslav pointed to.


On Wednesday, October 24, 2012 2:08:37 PM UTC-7, kapouer wrote:
That shouldn't stop the build ?

If it does, try fiddling with
TESTFLAGS="--no-presubmit"

J�r�my.
Reply all
Reply to author
Forward
0 new messages