Use AST's type field and merge types for unary, binary & compare ICs (issue 17468003)

3 views
Skip to first unread message

ross...@chromium.org

unread,
Jun 19, 2013, 11:53:47 AM6/19/13
to jkum...@chromium.org, v8-...@googlegroups.com
Reviewers: Jakob,

Description:
Use AST's type field and merge types for unary, binary & compare ICs

R=jkum...@chromium.org
BUG=

Please review this at https://codereview.chromium.org/17468003/

SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge

Affected files:
M src/arm/code-stubs-arm.cc
M src/arm/lithium-arm.cc
M src/arm/lithium-codegen-arm.cc
M src/ast.h
M src/ast.cc
M src/code-stubs.h
M src/globals.h
M src/hydrogen-instructions.h
M src/hydrogen-instructions.cc
M src/hydrogen.cc
M src/ia32/code-stubs-ia32.cc
M src/ia32/lithium-codegen-ia32.cc
M src/ia32/lithium-ia32.cc
M src/ic.cc
M src/objects.h
M src/objects.cc
M src/type-info.h
M src/type-info.cc
M src/typing.h
M src/typing.cc
M src/x64/code-stubs-x64.cc
M src/x64/lithium-codegen-x64.cc
M src/x64/lithium-x64.cc


jkum...@chromium.org

unread,
Jun 20, 2013, 10:08:55 AM6/20/13
to ross...@chromium.org, v8-...@googlegroups.com
Maybe<LGTM> :-P


https://codereview.chromium.org/17468003/diff/8001/src/types.cc
File src/types.cc (right):

https://codereview.chromium.org/17468003/diff/8001/src/types.cc#newcode341
src/types.cc:341: return Type::Any();
nit: {} please, and 2-space indentation.

https://codereview.chromium.org/17468003/diff/8001/src/types.cc#newcode417
src/types.cc:417: return Type::None();
nit: {} please, and 2-space indentation.

https://codereview.chromium.org/17468003/

ross...@chromium.org

unread,
Jun 21, 2013, 7:10:24 AM6/21/13
to jkum...@chromium.org, v8-...@googlegroups.com
Committed patchset #4 manually as r15264 (presubmit successful).

https://codereview.chromium.org/17468003/
Reply all
Reply to author
Forward
0 new messages