Groups
Groups
Sign in
Groups
Groups
v8-dev
Conversations
About
Send feedback
Help
Add fast path for FastProperty objects in JSON.stringify. (issue 11363078)
7 views
Skip to first unread message
yan...@chromium.org
unread,
Nov 5, 2012, 7:38:29 AM
11/5/12
Reply to author
Sign in to reply to author
Forward
Sign in to forward
Delete
You do not have permission to delete messages in this group
Copy link
Report message
Show original message
Either email addresses are anonymous for this group or you need the view member email addresses permission to view the original message
to verw...@chromium.org, v8-...@googlegroups.com
Reviewers: Toon Verwaest,
Description:
Add fast path for FastProperty objects in JSON.stringify.
R=
verw...@chromium.org
BUG=
Please review this at
https://chromiumcodereview.appspot.com/11363078/
SVN Base:
https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/json-stringifier.h
M test/mjsunit/harmony/proxies-json.js
M test/mjsunit/json2.js
verw...@chromium.org
unread,
Nov 5, 2012, 7:57:35 AM
11/5/12
Reply to author
Sign in to reply to author
Forward
Sign in to forward
Delete
You do not have permission to delete messages in this group
Copy link
Report message
Show original message
Either email addresses are anonymous for this group or you need the view member email addresses permission to view the original message
to yan...@chromium.org, v8-...@googlegroups.com
lgtm if you add the IsDeleted() check. This should not happen right now
anyway;
but just in case.
http://codereview.chromium.org/11363078/diff/1/src/json-stringifier.h
File src/json-stringifier.h (right):
http://codereview.chromium.org/11363078/diff/1/src/json-stringifier.h#newcode581
src/json-stringifier.h:581: if (details.type() == FIELD && !map_changed)
{
Also check for IsDeleted().
http://codereview.chromium.org/11363078/
Reply all
Reply to author
Forward
0 new messages