Add fast path for FastProperty objects in JSON.stringify. (issue 11363078)

7 views
Skip to first unread message

yan...@chromium.org

unread,
Nov 5, 2012, 7:38:29 AM11/5/12
to verw...@chromium.org, v8-...@googlegroups.com
Reviewers: Toon Verwaest,

Description:
Add fast path for FastProperty objects in JSON.stringify.

R=verw...@chromium.org
BUG=


Please review this at https://chromiumcodereview.appspot.com/11363078/

SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge

Affected files:
M src/json-stringifier.h
M test/mjsunit/harmony/proxies-json.js
M test/mjsunit/json2.js


verw...@chromium.org

unread,
Nov 5, 2012, 7:57:35 AM11/5/12
to yan...@chromium.org, v8-...@googlegroups.com
lgtm if you add the IsDeleted() check. This should not happen right now
anyway;
but just in case.


http://codereview.chromium.org/11363078/diff/1/src/json-stringifier.h
File src/json-stringifier.h (right):

http://codereview.chromium.org/11363078/diff/1/src/json-stringifier.h#newcode581
src/json-stringifier.h:581: if (details.type() == FIELD && !map_changed)
{
Also check for IsDeleted().

http://codereview.chromium.org/11363078/
Reply all
Reply to author
Forward
0 new messages