Ensure that we do not accidentally emit debug code. (issue 11108011)

[mstar...@chromium.org]

LGTM (with a few nits).


https://codereview.chromium.org/11108011/diff/1/src/arm/lithium-codegen-arm.cc
File src/arm/lithium-codegen-arm.cc (right):

https://codereview.chromium.org/11108011/diff/1/src/arm/lithium-codegen-arm.cc#newcode4277
src/arm/lithium-codegen-arm.cc:4277: __ AssertSmi(r0);
Indentation is off.

https://codereview.chromium.org/11108011/diff/1/src/x64/code-stubs-x64.cc
File src/x64/code-stubs-x64.cc (right):

https://codereview.chromium.org/11108011/diff/1/src/x64/code-stubs-x64.cc#newcode1300
src/x64/code-stubs-x64.cc:1300: __ AssertRootValue(heap_number_map,
Indentation is off.

https://codereview.chromium.org/11108011/diff/1/src/x64/lithium-codegen-x64.cc
File src/x64/lithium-codegen-x64.cc (right):

https://codereview.chromium.org/11108011/diff/1/src/x64/lithium-codegen-x64.cc#newcode4207
src/x64/lithium-codegen-x64.cc:4207: __ AssertSmi(input);
Indentation is off.

https://codereview.chromium.org/11108011/

[sven...@chromium.org]

Reviewers: Michael Starzinger,

Message:
Fixed nits, landing...

https://codereview.chromium.org/11108011/diff/1/src/arm/lithium-codegen-arm.cc
File src/arm/lithium-codegen-arm.cc (right):

https://codereview.chromium.org/11108011/diff/1/src/arm/lithium-codegen-arm.cc#newcode4277
src/arm/lithium-codegen-arm.cc:4277: __ AssertSmi(r0);

On 2012/10/12 11:00:22, Michael Starzinger wrote:
> Indentation is off.

Done.

https://codereview.chromium.org/11108011/diff/1/src/x64/code-stubs-x64.cc
File src/x64/code-stubs-x64.cc (right):

https://codereview.chromium.org/11108011/diff/1/src/x64/code-stubs-x64.cc#newcode1300
src/x64/code-stubs-x64.cc:1300: __ AssertRootValue(heap_number_map,

On 2012/10/12 11:00:22, Michael Starzinger wrote:
> Indentation is off.

Done.

https://codereview.chromium.org/11108011/diff/1/src/x64/lithium-codegen-x64.cc
File src/x64/lithium-codegen-x64.cc (right):

https://codereview.chromium.org/11108011/diff/1/src/x64/lithium-codegen-x64.cc#newcode4207
src/x64/lithium-codegen-x64.cc:4207: __ AssertSmi(input);

On 2012/10/12 11:00:22, Michael Starzinger wrote:
> Indentation is off.

Done.

Description:
Ensure that we do not accidentally emit debug code.

The call sites are more concise, the naming is better and at least one
case of superfluous code in release mode was removed.

R=mstar...@chromium.org


Please review this at https://codereview.chromium.org/11108011/

SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge

Affected files:
M src/arm/code-stubs-arm.cc
M src/arm/full-codegen-arm.cc
M src/arm/lithium-codegen-arm.cc
M src/arm/macro-assembler-arm.h
M src/arm/macro-assembler-arm.cc
M src/ia32/code-stubs-ia32.cc
M src/ia32/full-codegen-ia32.cc
M src/ia32/lithium-codegen-ia32.cc
M src/ia32/macro-assembler-ia32.h
M src/ia32/macro-assembler-ia32.cc
M src/mips/code-stubs-mips.cc
M src/mips/full-codegen-mips.cc
M src/mips/lithium-codegen-mips.cc
M src/mips/macro-assembler-mips.h
M src/mips/macro-assembler-mips.cc
M src/x64/code-stubs-x64.cc
M src/x64/full-codegen-x64.cc
M src/x64/lithium-codegen-x64.cc
M src/x64/macro-assembler-x64.h
M src/x64/macro-assembler-x64.cc