Received: by 10.42.163.65 with SMTP id b1mr35351504icy.2.1325692140418;
        Wed, 04 Jan 2012 07:49:00 -0800 (PST)
X-BeenThere: v8-dev@googlegroups.com
Received: by 10.231.66.195 with SMTP id o3ls11695974ibi.4.gmail; Wed, 04 Jan
 2012 07:48:59 -0800 (PST)
Received: by 10.50.153.200 with SMTP id vi8mr27437790igb.3.1325692139627;
        Wed, 04 Jan 2012 07:48:59 -0800 (PST)
Received: by 10.50.153.200 with SMTP id vi8mr27437788igb.3.1325692139618;
        Wed, 04 Jan 2012 07:48:59 -0800 (PST)
Return-Path: <363QETwoJBmQGTKM.EQTTaIOCKN.EQOXk-FGXIQQINGITQWRU....@m3kw2wvrgufz5godrsrytgd7.apphosting.bounces.google.com>
Received: from mail-tul01m020-f198.google.com (mail-tul01m020-f198.google.com [209.85.214.198])
        by gmr-mx.google.com with ESMTPS id dk6si5810960igb.1.2012.01.04.07.48.59
        (version=TLSv1/SSLv3 cipher=OTHER);
        Wed, 04 Jan 2012 07:48:59 -0800 (PST)
Received-SPF: pass (google.com: domain of 363QETwoJBmQGTKM.EQTTaIOCKN.EQOXk-FGXIQQINGITQWRU....@m3kw2wvrgufz5godrsrytgd7.apphosting.bounces.google.com designates 209.85.214.198 as permitted sender) client-ip=209.85.214.198;
Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of 363QETwoJBmQGTKM.EQTTaIOCKN.EQOXk-FGXIQQINGITQWRU....@m3kw2wvrgufz5godrsrytgd7.apphosting.bounces.google.com designates 209.85.214.198 as permitted sender) smtp.mail=363QETwoJBmQGTKM.EQTTaIOCKN.EQOXk-FGXIQQINGITQWRU....@m3kw2wvrgufz5godrsrytgd7.apphosting.bounces.google.com
Received: by obcuz6 with SMTP id uz6so35962835obc.9
        for <v8-dev@googlegroups.com>; Wed, 04 Jan 2012 07:48:59 -0800 (PST)
MIME-Version: 1.0
Received: by 10.50.180.228 with SMTP id dr4mr27462693igc.3.1325692139185; Wed,
 04 Jan 2012 07:48:59 -0800 (PST)
Reply-To: erik.co...@gmail.com, vego...@chromium.org, v8-dev@googlegroups.com
Message-ID: <14dae93408c509a84604b5b5c170@google.com>
Date: Wed, 04 Jan 2012 15:48:59 +0000
Subject: Re: Randomize the seed used for string hashing.  This helps guard
 against (issue 9086006)
From: erik.co...@gmail.com
To: vego...@chromium.org
Cc: v8-dev@googlegroups.com
Content-Type: text/plain; charset=ISO-8859-1; format=flowed; delsp=yes


http://codereview.chromium.org/9086006/diff/1/src/flag-definitions.h
File src/flag-definitions.h (right):

http://codereview.chromium.org/9086006/diff/1/src/flag-definitions.h#newcode352
src/flag-definitions.h:352: DEFINE_bool(randomize_string_hashes,
On 2012/01/04 14:30:57, Vyacheslav Egorov wrote:
> Maybe it should be noted that data in the snapshot (if present) will
supersede
> these flags

Done.

http://codereview.chromium.org/9086006/diff/1/src/mips/code-stubs-mips.cc
File src/mips/code-stubs-mips.cc (left):

http://codereview.chromium.org/9086006/diff/1/src/mips/code-stubs-mips.cc#oldcode5929
src/mips/code-stubs-mips.cc:5929: // hash = character + (character <<
10);
On 2012/01/04 14:30:57, Vyacheslav Egorov wrote:
> comment is outdated

Done.

http://codereview.chromium.org/9086006/diff/1/src/objects.cc
File src/objects.cc (right):

http://codereview.chromium.org/9086006/diff/1/src/objects.cc#newcode6696
src/objects.cc:6696: #endif
On 2012/01/04 14:30:57, Vyacheslav Egorov wrote:
> I think this should be checked only when slow assertions are enabled.

Done.

http://codereview.chromium.org/9086006/