Received: by 10.224.39.70 with SMTP id f6mr1115486qae.2.1336042582749;
        Thu, 03 May 2012 03:56:22 -0700 (PDT)
X-BeenThere: v8-dev@googlegroups.com
Received: by 10.229.136.134 with SMTP id r6ls705146qct.8.gmail; Thu, 03 May
 2012 03:56:22 -0700 (PDT)
Received: by 10.224.217.200 with SMTP id hn8mr1111694qab.4.1336042582046;
        Thu, 03 May 2012 03:56:22 -0700 (PDT)
Received: by 10.224.217.200 with SMTP id hn8mr1111693qab.4.1336042582037;
        Thu, 03 May 2012 03:56:22 -0700 (PDT)
Return-Path: <3VWSiTxUJACoINXUSOaSIUJKXKbOKc-NXMSGOR....@m3kw2wvrgufz5godrsrytgd7.apphosting.bounces.google.com>
Received: from mail-qa0-f70.google.com (mail-qa0-f70.google.com [209.85.216.70])
        by gmr-mx.google.com with ESMTPS id c25si1803803qch.2.2012.05.03.03.56.22
        (version=TLSv1/SSLv3 cipher=OTHER);
        Thu, 03 May 2012 03:56:22 -0700 (PDT)
Received-SPF: pass (google.com: domain of 3VWSiTxUJACoINXUSOaSIUJKXKbOKc-NXMSGOR....@m3kw2wvrgufz5godrsrytgd7.apphosting.bounces.google.com designates 209.85.216.70 as permitted sender) client-ip=209.85.216.70;
Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of 3VWSiTxUJACoINXUSOaSIUJKXKbOKc-NXMSGOR....@m3kw2wvrgufz5godrsrytgd7.apphosting.bounces.google.com designates 209.85.216.70 as permitted sender) smtp.mail=3VWSiTxUJACoINXUSOaSIUJKXKbOKc-NXMSGOR....@m3kw2wvrgufz5godrsrytgd7.apphosting.bounces.google.com
Received: by qadc10 with SMTP id c10so245827qad.9
        for <v8-dev@googlegroups.com>; Thu, 03 May 2012 03:56:21 -0700 (PDT)
        d=google.com; s=20120113;
        h=mime-version:reply-to:x-google-appengine-app-id:message-id:date
         :subject:from:to:cc:content-type:x-gm-message-state;
        bh=PcD3v0RY5XqR6R9+JaCSFsyDa4a/kdOu7OPwZf/e7SM=;
        b=UG+V/qm7GM3hbj61TXnzf77q8tZstX8O8LZMMmmyhE28QZXxDNSxnkpewZzNkmTce3
         BcfPvUooD7funn0YUgWFHg81y0EO19VBDcwXApwzGNFJa9c7VrSy9UYnjE7BD5Up+cId
         uWAK8O7CnoiTgqI3WhuQicFLmxE+JdxpTyuQRpEbOLK+HnFkGmko1QhV/NWGHGFbHZy3
         tX8HJaXY5Ka6IYRqDYmPfJLKQeW80P3lhDu/q00N/fk8VUJmMy7DmQtLPvrL3tixMZYy
         Dax4LGbANc/O1paYyaJNx5EeFdtz7KBOdsbtCf1v0sQPIyNKB5wd/jeT95EvR1jbFFUK
         Ua3w==
MIME-Version: 1.0
Received: by 10.236.201.229 with SMTP id b65mr2320660yho.9.1336042581897; Thu,
 03 May 2012 03:56:21 -0700 (PDT)
Reply-To: mstarzin...@chromium.org, vego...@chromium.org, 
	v8-dev@googlegroups.com
Message-ID: <20cf3056423d7fb49704bf1fa...@google.com>
Date: Thu, 03 May 2012 10:56:21 +0000
Subject: Re: Implement clearing of CompareICs. (issue 10263008)
From: mstarzin...@chromium.org
To: vego...@chromium.org
Cc: v8-dev@googlegroups.com
Content-Type: text/plain; charset=ISO-8859-1; format=flowed; delsp=yes
X-Gm-Message-State: ALoCoQn71BOBvHh1otL+U4UaV4qUbX6NdKtcOi1liAkuOGz00HCdM8cwCQp9/MmoBuIqM/Do8gZz

Addressed comments. Rebased. Landed.


https://chromiumcodereview.appspot.com/10263008/diff/12001/src/arm/ic-arm.cc
File src/arm/ic-arm.cc (right):

https://chromiumcodereview.appspot.com/10263008/diff/12001/src/arm/ic-arm.cc#newcode1732
src/arm/ic-arm.cc:1732: // This is patching a conditional "jump
if/if-not smi" site.
On 2012/05/02 11:29:48, Vyacheslav Egorov wrote:
> I think to align with code snippets below this should be jump if not
smi/jump if
> smi.

Done.

https://chromiumcodereview.appspot.com/10263008/diff/12001/src/x64/ic-x64.cc
File src/x64/ic-x64.cc (right):

https://chromiumcodereview.appspot.com/10263008/diff/12001/src/x64/ic-x64.cc#newcode1770
src/x64/ic-x64.cc:1770: // short jump-if-carry/not-carry at this
position.
On 2012/05/02 11:29:48, Vyacheslav Egorov wrote:
> Please update the comment just like in ia32

Done.

https://chromiumcodereview.appspot.com/10263008/