Re: Implement clearing of CompareICs. (issue 10263008)

unread,

May 2, 2012, 7:07:23 AM5/2/12

to veg...@chromium.org, v8-...@googlegroups.com

Ported to x64 and ARM. Addressed comments. PTAL.

https://chromiumcodereview.appspot.com/10263008/diff/1/src/ic.cc
File src/ic.cc (right):

https://chromiumcodereview.appspot.com/10263008/diff/1/src/ic.cc#newcode415
src/ic.cc:415: if (target->compare_state() == UNINITIALIZED) return;
On 2012/04/30 14:27:10, Vyacheslav Egorov wrote:
> We can limit clearing to those states that can retain objects.

Done.

https://chromiumcodereview.appspot.com/10263008/diff/1/src/ic.cc#newcode2469
src/ic.cc:2469: Code* CompareIC::initialize_stub(Token::Value op) {
On 2012/04/30 14:27:10, Vyacheslav Egorov wrote:
> I guess it should be called GetUnitializedStub() or something. (naming
convetion
> limits foo_bar methods to getters).

Done. Renamed to GetRawUninitialized() to be in sync with the handlified
version a few lines below. We might consider renaming the stub accessors
for LoadICs and StoreICs as well at some point.

https://chromiumcodereview.appspot.com/10263008/

unread,

May 2, 2012, 7:29:48 AM5/2/12

to mstar...@chromium.org, v8-...@googlegroups.com

lgtm

https://chromiumcodereview.appspot.com/10263008/diff/12001/src/arm/ic-arm.cc
File src/arm/ic-arm.cc (right):

https://chromiumcodereview.appspot.com/10263008/diff/12001/src/arm/ic-arm.cc#newcode1732
src/arm/ic-arm.cc:1732: // This is patching a conditional "jump
if/if-not smi" site.
I think to align with code snippets below this should be jump if not
smi/jump if smi.

https://chromiumcodereview.appspot.com/10263008/diff/12001/src/x64/ic-x64.cc
File src/x64/ic-x64.cc (right):

https://chromiumcodereview.appspot.com/10263008/diff/12001/src/x64/ic-x64.cc#newcode1770
src/x64/ic-x64.cc:1770: // short jump-if-carry/not-carry at this
position.
Please update the comment just like in ia32

https://chromiumcodereview.appspot.com/10263008/

unread,

May 3, 2012, 6:56:21 AM5/3/12

to veg...@chromium.org, v8-...@googlegroups.com

Addressed comments. Rebased. Landed.

On 2012/05/02 11:29:48, Vyacheslav Egorov wrote:
> I think to align with code snippets below this should be jump if not
smi/jump if
> smi.

Done.

On 2012/05/02 11:29:48, Vyacheslav Egorov wrote:
> Please update the comment just like in ia32

Reply all

Reply to author

Forward