Received: by 10.236.193.8 with SMTP id j8mr9004957yhn.3.1336563034416;
        Wed, 09 May 2012 04:30:34 -0700 (PDT)
X-BeenThere: v8-dev@googlegroups.com
Received: by 10.236.176.198 with SMTP id b46ls9114738yhm.2.gmail; Wed, 09 May
 2012 04:30:33 -0700 (PDT)
Received: by 10.236.201.229 with SMTP id b65mr32855696yho.9.1336563033631;
        Wed, 09 May 2012 04:30:33 -0700 (PDT)
Received: by 10.236.201.229 with SMTP id b65mr32855695yho.9.1336563033620;
        Wed, 09 May 2012 04:30:33 -0700 (PDT)
Return-Path: <3WVWqTxUJADAOTdaYUgYOaPQdQhUQi-TdSYMUX....@m3kw2wvrgufz5godrsrytgd7.apphosting.bounces.google.com>
Received: from mail-yw0-f70.google.com (mail-yw0-f70.google.com [209.85.213.70])
        by gmr-mx.google.com with ESMTPS id z24si2543495yhh.1.2012.05.09.04.30.33
        (version=TLSv1/SSLv3 cipher=OTHER);
        Wed, 09 May 2012 04:30:33 -0700 (PDT)
Received-SPF: pass (google.com: domain of 3WVWqTxUJADAOTdaYUgYOaPQdQhUQi-TdSYMUX....@m3kw2wvrgufz5godrsrytgd7.apphosting.bounces.google.com designates 209.85.213.70 as permitted sender) client-ip=209.85.213.70;
Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of 3WVWqTxUJADAOTdaYUgYOaPQdQhUQi-TdSYMUX....@m3kw2wvrgufz5godrsrytgd7.apphosting.bounces.google.com designates 209.85.213.70 as permitted sender) smtp.mail=3WVWqTxUJADAOTdaYUgYOaPQdQhUQi-TdSYMUX....@m3kw2wvrgufz5godrsrytgd7.apphosting.bounces.google.com
Received: by yhoo21 with SMTP id o21so273092yho.1
        for <v8-dev@googlegroups.com>; Wed, 09 May 2012 04:30:33 -0700 (PDT)
        d=google.com; s=20120113;
        h=mime-version:reply-to:x-google-appengine-app-id:message-id:date
         :subject:from:to:cc:content-type:x-gm-message-state;
        bh=Ur60e5VgWViZOPJegsXm0uy+ZnhcEehFtiGrN99nLrU=;
        b=HOssEjv5ML/kttQ8qZY+5WamoXwYLkMRmYA+MwJywEjxC7ODE4b5eHTK5vS17PFuJp
         cZ/LtsfZzfCyWXUvMwzEjgAO6PY9984SJ7uRrn0gmHO1pgo1NukhuXqInEQtGH+RL7b+
         b7CbOhqNYfqbM882Q8Jg0FehsTLescpVuM2Mp7mFcdCXLUgnpniPrN+PLAr1pO8uV64O
         kulbK9eYQAwBKm6PeBDVKqkAj/WwIPjv1nljlvOpC31VoTRt4i1NVllWeoDn5U8+JCFf
         8IJG4a2Wfn3fEUOMkA/2LDa2Ee2izz9yy+JzW9Aoc0+BSmdYnQXsUkt9M4xiV6nOLj+u
         d8iA==
MIME-Version: 1.0
Received: by 10.101.94.7 with SMTP id w7mr9870665anl.22.1336563033488; Wed, 09
 May 2012 04:30:33 -0700 (PDT)
Reply-To: da...@chromium.org, jkumme...@chromium.org, fschnei...@chromium.org, 
	v8-dev@googlegroups.com
Message-ID: <001636ed6ae3d4c03e04bf98d...@google.com>
Date: Wed, 09 May 2012 11:30:33 +0000
Subject: Re: Implement tracking and optimizations of packed arrays. (issue 10209027)
From: fschnei...@chromium.org
To: da...@chromium.org, jkumme...@chromium.org
Cc: v8-dev@googlegroups.com
Content-Type: text/plain; charset=ISO-8859-1; format=flowed; delsp=yes
X-Gm-Message-State: ALoCoQm7sPp5WFa9EyfXIne2jBfWEPmTRFEqh4lSBPKMg7QimBF9HB7E6RI52j2ecyVHfCF6LHZY

dbc:

I have a CL that addes MUST_USE_RESULT to all functions in elements.h that
return a MaybeObject*.


https://chromiumcodereview.appspot.com/10209027/diff/3001/src/objects.cc
File src/objects.cc (right):

https://chromiumcodereview.appspot.com/10209027/diff/3001/src/objects.cc#newcode8508
src/objects.cc:8508: accessor->CopyElements(this, new_elements,
new_elements_kind);
Missing check for failure? CopyElements has a MaybeObject* return type.

https://chromiumcodereview.appspot.com/10209027/diff/3001/src/objects.cc#newcode9408
src/objects.cc:9408: ValidateElements();
Maybe check result for failure before calling ValidateElements?

https://chromiumcodereview.appspot.com/10209027/