Re: Implement tracking and optimizations of packed arrays. (issue 10209027)

7 views
Skip to first unread message

fschn...@chromium.org

unread,
May 9, 2012, 7:30:33 AM5/9/12
to da...@chromium.org, jkum...@chromium.org, v8-...@googlegroups.com
dbc:

I have a CL that addes MUST_USE_RESULT to all functions in elements.h that
return a MaybeObject*.


https://chromiumcodereview.appspot.com/10209027/diff/3001/src/objects.cc
File src/objects.cc (right):

https://chromiumcodereview.appspot.com/10209027/diff/3001/src/objects.cc#newcode8508
src/objects.cc:8508: accessor->CopyElements(this, new_elements,
new_elements_kind);
Missing check for failure? CopyElements has a MaybeObject* return type.

https://chromiumcodereview.appspot.com/10209027/diff/3001/src/objects.cc#newcode9408
src/objects.cc:9408: ValidateElements();
Maybe check result for failure before calling ValidateElements?

https://chromiumcodereview.appspot.com/10209027/
Reply all
Reply to author
Forward
0 new messages