MIPS: Consistently use named getters for Lithium operands on ARM. (issue 11109003)

15 views
Skip to first unread message

pal...@homejinni.com

unread,
Oct 11, 2012, 6:49:55 PM10/11/12
to sven...@chromium.org, da...@chromium.org, pli...@gmail.com, ger...@homejinni.com, v8-...@googlegroups.com
Reviewers: Sven Panne, danno, Paul Lind, kisg,

Description:
MIPS: Consistently use named getters for Lithium operands on ARM.

Port r12527 (24ed881a)

BUG=
TEST=


Please review this at https://chromiumcodereview.appspot.com/11109003/

SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge

Affected files:
M src/mips/lithium-codegen-mips.cc
M src/mips/lithium-mips.h
M src/mips/lithium-mips.cc


sven...@chromium.org

unread,
Oct 12, 2012, 2:53:05 AM10/12/12
to pal...@homejinni.com, da...@chromium.org, pli...@gmail.com, ger...@homejinni.com, v8-...@googlegroups.com
LGTM (in a rubberstamp-ish way... ;-)

https://codereview.chromium.org/11109003/

sven...@chromium.org

unread,
Oct 12, 2012, 3:02:35 AM10/12/12
to pal...@homejinni.com, da...@chromium.org, pli...@gmail.com, ger...@homejinni.com, v8-...@googlegroups.com
There were 2 tiny compilation problems in debug mode which I fixed.
Landing...

https://codereview.chromium.org/11109003/
Reply all
Reply to author
Forward
0 new messages