                                                                                                                                                                                                                                                                
Received-SPF: pass (google.com: domain of si...@google.com designates 209.85.216.177 as permitted sender) client-ip=209.85.216.177;
MIME-Version: 1.0
Sender: si...@google.com
In-Reply-To: <047d7b5d8521a32aa104c85f4...@google.com>
References: <047d7b5d8521a32aa104c85f4...@google.com>
Date: Wed, 29 Aug 2012 09:45:03 -0400
Message-ID: <CAJfD1ZG-u4TR9H4omKjHJtiDfbXxt1CtPowBtF0JAm5x=_1...@mail.gmail.com>
Subject: Re: Add a new API V8::SetJitCodeEventHandler to push code name and
 location to users such as profilers. (issue 10795074)
From: =?UTF-8?B?U2lndXLDsHVyIMOBc2dlaXJzc29u?= <si...@chromium.org>
To: si...@chromium.org, da...@chromium.org, mstarzin...@chromium.org, 
	mnaga...@chromium.org, bertbel...@gmail.com, i...@bnoordhuis.nl, 
	v8-dev@googlegroups.com
Content-Type: multipart/alternative; boundary=00235429dc240c8d4204c867c42a

--00235429dc240c8d4204c867c42a
Content-Type: text/plain; charset=UTF-8

On Tue, Aug 28, 2012 at 11:38 PM, <bertbel...@gmail.com> wrote:

> Nice to see this landed.
>
> I have one question:
>
>> * \note removal events are not currently issued.
>>
>
> Is that comment still relevant? There is some code where code remove
> events are
> dispatched.
>
> Yes, AFAICT this is still true. Certainly my test doesn't hit the
NOTREACHED I have for that case in my event handler.

If it is, what would need to be done no make CODE_REMOVED events work?
>
> It seems the GC doesn't issue notifications for removed objects, so
someone familiar with that code would have to comment (mstarzinger?).


> https://chromiumcodereview.**appspot.com/10795074/<https://chromiumcodereview.appspot.com/10795074/>
>

--00235429dc240c8d4204c867c42a
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div class=3D"gmail_extra">On Tue, Aug 28, 2012 at 11:38 PM,  <span dir=3D"=
ltr">&lt;<a href=3D"mailto:bertbel...@gmail.com" target=3D"_blank">bertbeld=
e...@gmail.com</a>&gt;</span> wrote:<br><div class=3D"gmail_quote"><blockquot=
e class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc sol=
id;padding-left:1ex">
Nice to see this landed.<br>
<br>
I have one question:<br>
<blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p=
x #ccc solid;padding-left:1ex">
* \note removal events are not currently issued.<br>
</blockquote>
<br>
Is that comment still relevant? There is some code where code remove events=
 are<br>
dispatched.<br>
<br></blockquote><div>Yes, AFAICT this is still true. Certainly my test doe=
sn&#39;t hit the NOTREACHED I have for that case in my event handler.</div>=
<div><br></div><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex=
;border-left:1px #ccc solid;padding-left:1ex">

If it is, what would need to be done no make CODE_REMOVED events work?<br>
<br></blockquote><div>It seems the GC doesn&#39;t issue notifications for r=
emoved objects, so someone familiar with that code would have to comment (m=
starzinger?). =C2=A0</div><div>=C2=A0</div><blockquote class=3D"gmail_quote=
" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">

<a href=3D"https://chromiumcodereview.appspot.com/10795074/" target=3D"_bla=
nk">https://chromiumcodereview.<u></u>appspot.com/10795074/</a><br>
</blockquote></div><br></div>

--00235429dc240c8d4204c867c42a--