Account Options

  1. Sign in
The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Google Groups Home
« Groups Home
Message from discussion Modify Object.{freeze,seal,isFrozen,i sSealed} to avoid the problematic "caller" method on Functions. (issue 11312247)
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
 
From:
To:
Cc:
Followup To:
Add Cc | Add Followup-to | Edit Subject
Subject:
Validation:
For verification purposes please type the characters you see in the picture below or the numbers you hear by clicking the accessibility icon. Listen and type the numbers you hear
 
rossb...@chromium.org  
View profile  
 More options Nov 16 2012, 7:28 am
From: rossb...@chromium.org
Date: Fri, 16 Nov 2012 12:28:55 +0000
Local: Fri, Nov 16 2012 7:28 am
Subject: Re: Modify Object.{freeze,seal,isFrozen,isSealed} to avoid the problematic "caller" method on Functions. (issue 11312247)
Hm, I'm not sure that this hack is the right way to approach the problem. It
actually points at a deeper issue with caller poisoning and our  
implementation
of it, which attempts to fix a hole in the spec (cf.
https://bugs.ecmascript.org/show_bug.cgi?id=310). I sent a mail to  
es-discuss in
the hope of finding a resolution.

For the time being, I'd suggest simply commenting out the check in
Object.observe, which is not crucial anyway.

https://codereview.chromium.org/11312247/diff/1/src/v8natives.js
File src/v8natives.js (right):

https://codereview.chromium.org/11312247/diff/1/src/v8natives.js#newc...
src/v8natives.js:1159: if (IS_SPEC_FUNCTION(obj)) {
IS_FUNCTION probably is more adequate here, since it shouldn't be a
proxy.

https://codereview.chromium.org/11312247/


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.