X-BeenThere: v8-dev@googlegroups.com
Received: by 10.150.38.5 with SMTP id l5ls127708ybl.1.p; Fri, 26 Feb 2010 
	00:20:30 -0800 (PST)
Received: by 10.150.47.17 with SMTP id u17mr118628ybu.27.1267172430645;
        Fri, 26 Feb 2010 00:20:30 -0800 (PST)
Received: by 10.150.47.17 with SMTP id u17mr118626ybu.27.1267172430627;
        Fri, 26 Feb 2010 00:20:30 -0800 (PST)
Return-Path: <3ToSHSwMMBqUGFPHMWTRNZR.TWLan-IJaLTTLQJLWTZUX....@apphosting.bounces.google.com>
Received: from mail-gy0-f198.google.com (mail-gy0-f198.google.com [209.85.160.198])
        by gmr-mx.google.com with ESMTP id 24si784693ywh.10.2010.02.26.00.20.30;
        Fri, 26 Feb 2010 00:20:30 -0800 (PST)
Received-SPF: pass (google.com: domain of 3ToSHSwMMBqUGFPHMWTRNZR.TWLan-IJaLTTLQJLWTZUX....@apphosting.bounces.google.com designates 209.85.160.198 as permitted sender) client-ip=209.85.160.198;
Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of 3ToSHSwMMBqUGFPHMWTRNZR.TWLan-IJaLTTLQJLWTZUX....@apphosting.bounces.google.com designates 209.85.160.198 as permitted sender) smtp.mail=3ToSHSwMMBqUGFPHMWTRNZR.TWLan-IJaLTTLQJLWTZUX....@apphosting.bounces.google.com
Received: by gyf3 with SMTP id 3so3621974gyf.1
        for <v8-dev@googlegroups.com>; Fri, 26 Feb 2010 00:20:30 -0800 (PST)
MIME-Version: 1.0
Reply-To: kasp...@chromium.org, b...@chromium.org, v8-dev@googlegroups.com
Received: by 10.101.144.30 with SMTP id w30mr50872ann.13.1267172430470; Fri, 
	26 Feb 2010 00:20:30 -0800 (PST)
Message-ID: <0016e6d27962965fb204807c92a8@google.com>
Date: Fri, 26 Feb 2010 08:20:30 +0000
Subject: Re: Add information about time spent in external callback to... 
	(issue661170)
From: b...@chromium.org
To: kasp...@chromium.org
Cc: v8-dev@googlegroups.com
Content-Type: text/plain; charset=ISO-8859-1; format=flowed; delsp=yes

LGTM,
   Lars


http://codereview.chromium.org/661170/diff/1/2
File src/heap.cc (right):

http://codereview.chromium.org/661170/diff/1/2#newcode4093
src/heap.cc:4093: PrintF("%s %.1f -> %.1f MB, %d / %d ms.\n",
Refactor printing into:
PrintF(...);
if (external_time > 0) PrintF(...);
PrintF("\n");

http://codereview.chromium.org/661170