Re: MIPS: Fix issue 2346 (order of operations in keyed store on arrays) and turn get-own-property-descr… (issue 10987086)

11 views
Skip to first unread message

pal...@homejinni.com

unread,
Oct 15, 2012, 8:07:27 PM10/15/12
to erik....@gmail.com, da...@chromium.org, pli...@gmail.com, ger...@homejinni.com, v8-...@googlegroups.com
Rebased on r12737 and fixed typos

https://chromiumcodereview.appspot.com/10987086/

da...@chromium.org

unread,
Oct 16, 2012, 4:27:47 AM10/16/12
to pal...@homejinni.com, erik....@gmail.com, pli...@gmail.com, ger...@homejinni.com, v8-...@googlegroups.com
LGTM with a nit that I'll fix when I land.


https://chromiumcodereview.appspot.com/10987086/diff/6001/src/mips/ic-mips.cc
File src/mips/ic-mips.cc (right):

https://chromiumcodereview.appspot.com/10987086/diff/6001/src/mips/ic-mips.cc#newcode1415
src/mips/ic-mips.cc:1415: &slow, kCheckMap, kDontIncrementLength,
nit: spacing. I'll fix when I land.

https://chromiumcodereview.appspot.com/10987086/
Reply all
Reply to author
Forward
0 new messages