Message from discussion
Use native context to retrieve ErrorMessageForCodeGenerationF romStrings (issue 11093073)
Received: by 10.236.85.135 with SMTP id u7mr106141yhe.32.1349961953173;
Thu, 11 Oct 2012 06:25:53 -0700 (PDT)
X-BeenThere: v8-dev@googlegroups.com
Received: by 10.236.154.232 with SMTP id h68ls2560714yhk.2.gmail; Thu, 11 Oct
2012 06:25:52 -0700 (PDT)
Received: by 10.236.200.194 with SMTP id z42mr546463yhn.13.1349961952489;
Thu, 11 Oct 2012 06:25:52 -0700 (PDT)
Received: by 10.236.200.194 with SMTP id z42mr546462yhn.13.1349961952477;
Thu, 11 Oct 2012 06:25:52 -0700 (PDT)
Return-Path: <338h2UBUJANQ27HEC8KC2E34H4L84M-7H6C08B....@2uix4h7xygsz66weerlq.apphosting.bounces.google.com>
Received: from mail-qc0-f200.google.com (mail-qc0-f200.google.com [209.85.216.200])
by gmr-mx.google.com with ESMTPS id x31si901872qco.0.2012.10.11.06.25.51
(version=TLSv1/SSLv3 cipher=OTHER);
Thu, 11 Oct 2012 06:25:51 -0700 (PDT)
Received-SPF: pass (google.com: domain of 338h2UBUJANQ27HEC8KC2E34H4L84M-7H6C08B....@2uix4h7xygsz66weerlq.apphosting.bounces.google.com designates 209.85.216.200 as permitted sender) client-ip=209.85.216.200;
Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of 338h2UBUJANQ27HEC8KC2E34H4L84M-7H6C08B....@2uix4h7xygsz66weerlq.apphosting.bounces.google.com designates 209.85.216.200 as permitted sender) smtp.mail=338h2UBUJANQ27HEC8KC2E34H4L84M-7H6C08B....@2uix4h7xygsz66weerlq.apphosting.bounces.google.com; dkim=pass header...@chromium.org
Received: by mail-qc0-f200.google.com with SMTP id l42so2495715qco.3
for <v8-dev@googlegroups.com>; Thu, 11 Oct 2012 06:25:51 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=chromium.org; s=google;
h=mime-version:reply-to:x-google-appengine-app-id:message-id:date
:subject:from:to:cc:content-type;
bh=AX0V8g/tjEr4ZelxXPwdz2wmS5ctIFQJauoimS7LIDk=;
b=MJl/la23I1YvADJ69SwZUYG/nZoTlzDXiiHUw4dUrprUqxwEMppucRKhi1DTXmSH5U
Zcg8HSkOi7ZJVgn23IJP37GuNFcectnKTWgm1mVBOUqNIKiK4yQu+3XM3KAMk/dbxRFs
D8BW2aRJ02f6InOuQRJUI4VcwWbJknoYNo0B4=
MIME-Version: 1.0
Received: by 10.58.73.135 with SMTP id l7mr200058vev.13.1349961951298; Thu, 11
Oct 2012 06:25:51 -0700 (PDT)
Reply-To: jkumme...@chromium.org, u...@chromium.org, v8-dev@googlegroups.com
Message-ID: <047d7b6d8cec9145bd04cbc88...@google.com>
Date: Thu, 11 Oct 2012 13:25:51 +0000
Subject: Use native context to retrieve ErrorMessageForCodeGenerationFromStrings
(issue 11093073)
From: jkumme...@chromium.org
To: u...@chromium.org
Cc: v8-dev@googlegroups.com
Content-Type: text/plain; charset=ISO-8859-1; format=flowed; delsp=yes
Reviewers: ulan,
Message:
PTAL.
Description:
Use native context to retrieve ErrorMessageForCodeGenerationFromStrings
BUG=155076
Please review this at https://codereview.chromium.org/11093073/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/runtime.cc
Index: src/runtime.cc
diff --git a/src/runtime.cc b/src/runtime.cc
index
735c77a2eca0b8e6ec227a5f488b630ce3a563ff..10ff1453ce279d098d2e4be3b72732742a34ae39
100644
--- a/src/runtime.cc
+++ b/src/runtime.cc
@@ -9083,7 +9083,7 @@ static ObjectPair CompileGlobalEval(Isolate* isolate,
if (native_context->allow_code_gen_from_strings()->IsFalse() &&
!CodeGenerationFromStringsAllowed(isolate, native_context)) {
Handle<Object> error_message =
- context->ErrorMessageForCodeGenerationFromStrings();
+ native_context->ErrorMessageForCodeGenerationFromStrings();
isolate->Throw(*isolate->factory()->NewEvalError(
"code_gen_from_strings", HandleVector<Object>(&error_message, 1)));
return MakePair(Failure::Exception(), NULL);