                                                                                                                                                                                                                                                                
Received-SPF: pass (google.com: domain of 3MwFrUBUJAGoKPZWUQcUKWLMZMdQMe-PZOUIQT....@2uix4h7xygsz66weerlq.apphosting.bounces.google.com designates 209.85.216.69 as permitted sender) client-ip=209.85.216.69;
MIME-Version: 1.0
Reply-To: da...@chromium.org, mstarzin...@chromium.org, 
	v8-dev@googlegroups.com
Message-ID: <047d7bd6b94614f1bb04cb14c...@google.com>
Date: Tue, 02 Oct 2012 14:58:59 +0000
Subject: Re: Age code to allow reclaiming old unexecuted functions (issue 10837037)
From: mstarzin...@chromium.org
To: da...@chromium.org
Cc: v8-dev@googlegroups.com
Content-Type: text/plain; charset=ISO-8859-1; format=flowed; delsp=yes

Second round with some follow-up comments, now that I am working on the
incremental code flushing. Also as discussed offline, this CL will require
rebasing after I land one of my CLs.


https://codereview.chromium.org/10837037/diff/16023/src/mark-compact.cc
File src/mark-compact.cc (right):

https://codereview.chromium.org/10837037/diff/16023/src/mark-compact.cc#newcode1205
src/mark-compact.cc:1205: return function->code()->IsOld() &&
IsFlushable(heap, shared_info);
See comment below.

https://codereview.chromium.org/10837037/diff/16023/src/mark-compact.cc#newcode1210
src/mark-compact.cc:1210: if (!shared_info->code()->IsOld()) return
false;
1) We shouldn't remove the check for the marking bit of the code,
because it makes sure that we don't throw away un-optimized code that is
required for bailout from optimized code.

2) Also I don't think it makes much sense to flush code that is strongly
reachable through other paths, that will rather lead to increased memory
consumption because we keep recompiling code without actually collecting
it.

3) Also it might be better to move this check further to the bottom,
because it is more expensive than the others I guess. But I don't have a
strong opinion about this last point.

https://codereview.chromium.org/10837037/