Change the Android makefile to use GCC 4.6 instead of GCC 4.4.3. (issue 11032018)

20 views
Skip to first unread message

ul...@chromium.org

unread,
Oct 2, 2012, 9:10:35 AM10/2/12
to jkum...@chromium.org, v8-...@googlegroups.com
Reviewers: Jakob,

Message:
PTAL

Description:
Change the Android makefile to use GCC 4.6 instead of GCC 4.4.3.

Android NDK 8b includes GCC 4.6

R=jkum...@chromium.org


Please review this at https://chromiumcodereview.appspot.com/11032018/

SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge

Affected files:
M Makefile.android


Index: Makefile.android
diff --git a/Makefile.android b/Makefile.android
index
a8d7fe148e4e7c2d498cd6316b5c71f5d6c96e1e..8e4ce0814ab6835dd59f4b55795f9a82cfef5f45
100644
--- a/Makefile.android
+++ b/Makefile.android
@@ -48,11 +48,11 @@ endif
ifeq ($(ARCH), android_arm)
DEFINES = target_arch=arm v8_target_arch=arm android_target_arch=arm
DEFINES += arm_neon=0 armv7=1
- TOOLCHAIN_ARCH = arm-linux-androideabi-4.4.3
+ TOOLCHAIN_ARCH = arm-linux-androideabi-4.6
else
ifeq ($(ARCH), android_ia32)
DEFINES = target_arch=ia32 v8_target_arch=ia32 android_target_arch=x86
- TOOLCHAIN_ARCH = x86-4.4.3
+ TOOLCHAIN_ARCH = x86-4.6
else
$(error Target architecture "${ARCH}" is not supported)
endif


jkum...@chromium.org

unread,
Oct 2, 2012, 9:14:31 AM10/2/12
to ul...@chromium.org, v8-...@googlegroups.com
LGTM.

Please also update the wiki page to reflect the new NDK requirements.

https://chromiumcodereview.appspot.com/11032018/
Reply all
Reply to author
Forward
0 new messages