Account Options

  1. Sign in
The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Google Groups Home
« Groups Home
Message from discussion r11591 committed - Fix shared library build errors....

Received: by 10.100.244.20 with SMTP id r20mr4982511anh.20.1337339727321;
        Fri, 18 May 2012 04:15:27 -0700 (PDT)
X-BeenThere: v8-dev@googlegroups.com
Received: by 10.101.26.31 with SMTP id d31ls573372anj.8.gmail; Fri, 18 May
 2012 04:15:26 -0700 (PDT)
Received: by 10.236.184.134 with SMTP id s6mr16718826yhm.1.1337339726464;
        Fri, 18 May 2012 04:15:26 -0700 (PDT)
Received: by 10.236.184.134 with SMTP id s6mr16718823yhm.1.1337339726454;
        Fri, 18 May 2012 04:15:26 -0700 (PDT)
Return-Path: <3Ti-2TxAKBgklxmn1r2n-wx0nyu7pxxpun.lxv4H-mn4pxxpunp0x3y1....@codesite.bounces.google.com>
Received: from mail-gg0-f203.google.com (mail-gg0-f203.google.com [209.85.161.203])
        by gmr-mx.google.com with ESMTPS id k35si7634382yhb.3.2012.05.18.04.15.26
        (version=TLSv1/SSLv3 cipher=OTHER);
        Fri, 18 May 2012 04:15:26 -0700 (PDT)
Received-SPF: pass (google.com: domain of 3Ti-2TxAKBgklxmn1r2n-wx0nyu7pxxpun.lxv4H-mn4pxxpunp0x3y1....@codesite.bounces.google.com designates 209.85.161.203 as permitted sender) client-ip=209.85.161.203;
Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of 3Ti-2TxAKBgklxmn1r2n-wx0nyu7pxxpun.lxv4H-mn4pxxpunp0x3y1....@codesite.bounces.google.com designates 209.85.161.203 as permitted sender) smtp.mail=3Ti-2TxAKBgklxmn1r2n-wx0nyu7pxxpun.lxv4H-mn4pxxpunp0x3y1....@codesite.bounces.google.com; dkim=pass header...@google.com
Received: by ggnd2 with SMTP id d2so58511ggn.0
        for <v8-dev@googlegroups.com>; Fri, 18 May 2012 04:15:26 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=google.com; s=20120113;
        h=mime-version:x-generated-by:message-id:date:subject:from:to
         :content-type;
        bh=Vn7Jmg9kVHe6nT5m5hVJ4mbNnfIsOStGMkD/hG6u4yc=;
        b=Kc+0qKQ3B3jUd7Og+fDOkMrPGSiV3PYXGYzinpFRqNbj69h4DnnOcB9F1/8PGkqilQ
         vtJIQJMYtKpX/LohRdWjOneJpW77/JX2QuSR+bMSzyxaleS3Lrv9iCqhfn3JsNrr8ysg
         Qad4kfnRMtCZFGQqv8DgG/LNa0fuHwyYCbZAo4kHMpL5RxKmzpP1vXTtzM8YKNsBmgD8
         ihcOeWlBT+2WlB17BBEAoo/cqT5xs1IieNVBwMXUgqcOAEzMb412yEsXQjSEao0zJtOY
         tqdSeqJCxoK/AkdKeIgoZDTWTfC5l4pFoexmLKy5WCbdLBTKSprwHkQa+6VnX8/ZxfcS
         PM1g==
MIME-Version: 1.0
Received: by 10.224.181.18 with SMTP id bw18mr7111260qab.2.1337339726353; Fri,
 18 May 2012 04:15:26 -0700 (PDT)
X-Generated-By: Google Code
Message-ID: <485b397dcf815557cc04c04da...@google.com>
Date: Fri, 18 May 2012 11:15:26 +0000
Subject: [v8] r11591 committed - Fix shared library build errors....
From: codesite-nore...@google.com
To: v8-dev@googlegroups.com
Content-Type: text/plain; charset=ISO-8859-1; format=flowed; delsp=yes

Revision: 11591
Author:   yang...@chromium.org
Date:     Fri May 18 04:15:14 2012
Log:      Fix shared library build errors.

R=jkumme...@chromium.org
BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com/10389203
http://code.google.com/p/v8/source/detail?r=11591

Modified:
  /branches/bleeding_edge/SConstruct

=======================================
--- /branches/bleeding_edge/SConstruct	Fri May 11 05:18:09 2012
+++ /branches/bleeding_edge/SConstruct	Fri May 18 04:15:14 2012
@@ -101,14 +101,14 @@
      'os:linux': {
        'CCFLAGS':      ['-ansi'] + GCC_EXTRA_CCFLAGS,
        'library:shared': {
-        'CPPDEFINES': ['V8_SHARED'],
+        'CPPDEFINES': ['V8_SHARED', 'BUILDING_V8_SHARED'],
          'LIBS': ['pthread']
        }
      },
      'os:macos': {
        'CCFLAGS':      ['-ansi', '-mmacosx-version-min=10.4'],
        'library:shared': {
-        'CPPDEFINES': ['V8_SHARED']
+        'CPPDEFINES': ['V8_SHARED', 'BUILDING_V8_SHARED'],
        }
      },
      'os:freebsd': {