Prepare for using GYP build on buildbots (issue 10383128)

15 views
Skip to first unread message

jkum...@chromium.org

unread,
May 11, 2012, 6:29:26 AM5/11/12
to yan...@chromium.org, v8-...@googlegroups.com
Reviewers: Yang,

Message:
Please take a look.

Happy to explain/discuss any of the changes.

Description:
Prepare for using GYP build on buildbots


Please review this at https://chromiumcodereview.appspot.com/10383128/

SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge

Affected files:
A DEPS
M Makefile
M SConstruct
M build/common.gypi
M build/gyp_v8
M build/standalone.gypi
M test/cctest/testcfg.py
M test/mjsunit/big-array-literal.js
M test/test262/testcfg.py
M tools/check-static-initializers.sh
M tools/presubmit.py
M tools/test-wrapper-gypbuild.py


yan...@chromium.org

unread,
May 11, 2012, 8:07:00 AM5/11/12
to jkum...@chromium.org, v8-...@googlegroups.com
LGTM with two comments.


https://chromiumcodereview.appspot.com/10383128/diff/1/DEPS
File DEPS (right):

https://chromiumcodereview.appspot.com/10383128/diff/1/DEPS#newcode27
DEPS:27: ]
Make sure the commit doesn't include the following lines.

https://chromiumcodereview.appspot.com/10383128/diff/1/test/test262/testcfg.py
File test/test262/testcfg.py (right):

https://chromiumcodereview.appspot.com/10383128/diff/1/test/test262/testcfg.py#newcode125
test/test262/testcfg.py:125: archive.extractall(u'\\\\?\\%s' %
self.root)
Maybe add a comment here.

https://chromiumcodereview.appspot.com/10383128/

jkum...@chromium.org

unread,
May 11, 2012, 8:17:01 AM5/11/12
to yan...@chromium.org, v8-...@googlegroups.com
On 2012/05/11 12:07:00, Yang wrote:
> Make sure the commit doesn't include the following lines.

Done.

https://chromiumcodereview.appspot.com/10383128/diff/1/test/test262/testcfg.py
File test/test262/testcfg.py (right):

https://chromiumcodereview.appspot.com/10383128/diff/1/test/test262/testcfg.py#newcode125
test/test262/testcfg.py:125: archive.extractall(u'\\\\?\\%s' %
self.root)
On 2012/05/11 12:07:00, Yang wrote:
> Maybe add a comment here.

Done.

https://chromiumcodereview.appspot.com/10383128/
Reply all
Reply to author
Forward
0 new messages