Received: by 10.224.111.140 with SMTP id s12mr533761qap.5.1352969841023; Thu, 15 Nov 2012 00:57:21 -0800 (PST) X-BeenThere: v8-dev@googlegroups.com Received: by 10.49.107.35 with SMTP id gz3ls193046qeb.52.gmail; Thu, 15 Nov 2012 00:57:19 -0800 (PST) Received: by 10.52.16.113 with SMTP id f17mr53244vdd.3.1352969839531; Thu, 15 Nov 2012 00:57:19 -0800 (PST) Received: by 10.52.16.113 with SMTP id f17mr53243vdd.3.1352969839522; Thu, 15 Nov 2012 00:57:19 -0800 (PST) Return-Path: <3bq6kUBUJAOcLQaXVRdVLXMNaNeRNf-QaPVJRU....@2uix4h7xygsz66weerlq.apphosting.bounces.google.com> Received: from mail-vc0-f199.google.com (mail-vc0-f199.google.com [209.85.220.199]) by gmr-mx.google.com with ESMTPS id es5si4325029vdb.2.2012.11.15.00.57.18 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 15 Nov 2012 00:57:18 -0800 (PST) Received-SPF: pass (google.com: domain of 3bq6kUBUJAOcLQaXVRdVLXMNaNeRNf-QaPVJRU....@2uix4h7xygsz66weerlq.apphosting.bounces.google.com designates 209.85.220.199 as permitted sender) client-ip=209.85.220.199; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of 3bq6kUBUJAOcLQaXVRdVLXMNaNeRNf-QaPVJRU....@2uix4h7xygsz66weerlq.apphosting.bounces.google.com designates 209.85.220.199 as permitted sender) smtp.mail=3bq6kUBUJAOcLQaXVRdVLXMNaNeRNf-QaPVJRU....@2uix4h7xygsz66weerlq.apphosting.bounces.google.com; dkim=pass header...@chromium.org Received: by mail-vc0-f199.google.com with SMTP id gb23so2345931vcb.2 for ; Thu, 15 Nov 2012 00:57:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:reply-to:x-google-appengine-app-id:message-id:date :subject:from:to:cc:content-type; bh=UatD/AseukbuJNGoyv1xWUWNeKhuiKvYJlCjKx2x2sc=; b=BTmyWChAqS/J/6UhH1yOWsikSRdtjfqQ43GyM53wYh5eHFpe8j/urBn7ywgwRUgGRU aH0Mdy2OoxlDUzi2ivxvXYWULc3OHb1aZ42pJ9efuRUgmd8lFb4Shjs+fln/EAU5SYC+ qx797+MNkg1MRh1gJ/++BPpsOCMz7GGaepANA= MIME-Version: 1.0 Received: by 10.58.210.198 with SMTP id mw6mr57818vec.22.1352969838386; Thu, 15 Nov 2012 00:57:18 -0800 (PST) Reply-To: aba...@chromium.org, svenpa...@chromium.org, jkumme...@chromium.org, da...@chromium.org, v8-dev@googlegroups.com, hara...@chromium.org, t...@chromium.org Message-ID: <047d7bd6ab869be03404ce84d...@google.com> Date: Thu, 15 Nov 2012 08:57:18 +0000 Subject: Re: Disable EXTRA_CHECKS in Release (issue 11275324) From: da...@chromium.org To: aba...@chromium.org, svenpa...@chromium.org, jkumme...@chromium.org Cc: v8-dev@googlegroups.com, hara...@chromium.org, t...@chromium.org Content-Type: text/plain; charset=ISO-8859-1; format=flowed; delsp=yes We landed the extra checks with the assumption that they wouldn't negatively impact perf (at least not significantly). Since that's true, and AFAIK there's been no remaining API abuse identified by crash dumps, we should disable it. https://codereview.chromium.org/11275324/