Account Options

  1. Sign in
The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Google Groups Home
« Groups Home
v8-dev
Home
+ new post
About this group
Join this group
Message from discussion Implement progress bar for large objects. (issue 11362246)
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
 
From:
To:
Cc:
Followup To:
Add Cc | Add Followup-to | Edit Subject
Subject:
Validation:
For verification purposes please type the characters you see in the picture below or the numbers you hear by clicking the accessibility icon. Listen and type the numbers you hear
 
u...@chromium.org  
View profile  
 More options Nov 15 2012, 4:54 am
From: u...@chromium.org
Date: Thu, 15 Nov 2012 09:54:23 +0000
Local: Thurs, Nov 15 2012 4:54 am
Subject: Re: Implement progress bar for large objects. (issue 11362246)
Print | View thread | Show original | Report this message | Find messages by this author
LGTM with few nits.

https://chromiumcodereview.appspot.com/11362246/diff/1/src/flag-defin...
File src/flag-definitions.h (right):

https://chromiumcodereview.appspot.com/11362246/diff/1/src/flag-defin...
src/flag-definitions.h:441: DEFINE_bool(use_progress_bar, false,
On 2012/11/14 12:21:04, hpayer1 wrote:

> should we mention large object in the parameter?

large_object_pogress_bar?

Agreed, "progress bar" sounds to ambiguous in flags. Maybe
"marking_progress_bar"?

https://chromiumcodereview.appspot.com/11362246/diff/1/src/incrementa...
File src/incremental-marking.cc (right):

https://chromiumcodereview.appspot.com/11362246/diff/1/src/incrementa...
src/incremental-marking.cc:237: int start_offset =
Max(FixedArray::BodyDescriptor::kStartOffset,
Not sure if worthwhile as the loop rarely executes more than once: we
could move the initialization of start_offset and end_offset out of the
loop, and at the end of loop do: start_offset = end_offset, end_offset =
Min(object_size, end_offset + kProgressBarScanningChunk);
This would allow to get rid of chunk->progress_bar() accesses in the
loop and do chunk->set_progress_bar(end_offset) once after the loop.

https://chromiumcodereview.appspot.com/11362246/diff/1/src/incrementa...
src/incremental-marking.cc:240: chunk->progress_bar() +
kProgressBarScanningChunk);
Shouldn't this be start_offset + kProgressBarScanningChunk ?

https://chromiumcodereview.appspot.com/11362246/diff/1/src/incrementa...
src/incremental-marking.cc:247: if (end_offset < object_size) {
(end_offset < object_size && !scan_until_end) would be more clear here.

https://chromiumcodereview.appspot.com/11362246/


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Create a group - Google Groups - Google Home - Terms of Service - Privacy Policy
©2013 Google