Fix typo in fast path for scanning json strings. (issue 11191055)

7 views
Skip to first unread message

verw...@chromium.org

unread,
Oct 18, 2012, 6:11:25 AM10/18/12
to yan...@chromium.org, v8-...@googlegroups.com
Reviewers: Yang,

Message:
PTAL

Description:
Fix typo in fast path for scanning json strings.


Please review this at https://chromiumcodereview.appspot.com/11191055/

SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge

Affected files:
M src/json-parser.h


Index: src/json-parser.h
diff --git a/src/json-parser.h b/src/json-parser.h
index
0b8cb769ca679676b85b3dd8884500a480f23800..d940c140464bd2c1fe567eeafc75231f39ef2514
100644
--- a/src/json-parser.h
+++ b/src/json-parser.h
@@ -584,7 +584,7 @@ Handle<String> JsonParser<seq_ascii>::ScanJsonString() {
position_,
position);
}
- if (c0_ < 0x20) return Handle<String>::null();
+ if (c0 < 0x20) return Handle<String>::null();
running_hash = StringHasher::AddCharacterCore(running_hash, c0);
position++;
if (position >= source_length_) return Handle<String>::null();


yan...@chromium.org

unread,
Oct 18, 2012, 6:39:06 AM10/18/12
to verw...@chromium.org, v8-...@googlegroups.com
On 2012/10/18 10:11:25, Toon Verwaest wrote:
> PTAL

LGTM.

https://chromiumcodereview.appspot.com/11191055/
Reply all
Reply to author
Forward
0 new messages