Don't leak inobject space when transforming to fast properties without descriptors. (issue 10828112)

10 views
Skip to first unread message

verw...@chromium.org

unread,
Aug 1, 2012, 6:43:51 AM8/1/12
to yan...@chromium.org, v8-...@googlegroups.com
Reviewers: Yang,

Message:
PTAL.

Description:
Don't leak inobject space when transforming to fast properties without
descriptors.


Please review this at https://chromiumcodereview.appspot.com/10828112/

SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge

Affected files:
M src/objects.cc


Index: src/objects.cc
diff --git a/src/objects.cc b/src/objects.cc
index
b092d8d67c6d0b62a48dc04abb1a0132e109bafd..6dbc41ea9c18d8a3cc852408ebf22846003c256d
100644
--- a/src/objects.cc
+++ b/src/objects.cc
@@ -12577,7 +12577,7 @@ MaybeObject*
StringDictionary::TransformPropertiesToFastFor(
if (instance_descriptor_length == 0) {
ASSERT_LE(unused_property_fields, inobject_props);
// Transform the object.
- new_map->set_unused_property_fields(unused_property_fields);
+ new_map->set_unused_property_fields(inobject_props);
obj->set_map(new_map);
obj->set_properties(heap->empty_fixed_array());
// Check that it really works.


yan...@chromium.org

unread,
Aug 1, 2012, 6:49:58 AM8/1/12
to verw...@chromium.org, v8-...@googlegroups.com
On 2012/08/01 10:43:51, Toon Verwaest wrote:
> PTAL.

LGTM.

https://chromiumcodereview.appspot.com/10828112/
Reply all
Reply to author
Forward
0 new messages