Account Options

  1. Sign in
The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Google Groups Home
« Groups Home
Message from discussion r12856 committed - Nano-refactoring: Simplify initialization...

Received: by 10.42.62.69 with SMTP id x5mr3517184ich.24.1352126278765;
        Mon, 05 Nov 2012 06:37:58 -0800 (PST)
X-BeenThere: v8-dev@googlegroups.com
Received: by 10.50.7.199 with SMTP id l7ls3800027iga.1.gmail; Mon, 05 Nov 2012
 06:37:57 -0800 (PST)
Received: by 10.66.83.161 with SMTP id r1mr3494227pay.28.1352126277867;
        Mon, 05 Nov 2012 06:37:57 -0800 (PST)
Received: by 10.66.83.161 with SMTP id r1mr3494226pay.28.1352126277856;
        Mon, 05 Nov 2012 06:37:57 -0800 (PST)
Return-Path: <3Rc-XUBAKBswu6vwA0Bw-569w73Gy66y3w.u64DQ-vwDy66y3wy96C7A....@codesite.bounces.google.com>
Received: from mail-pb0-f75.google.com (mail-pb0-f75.google.com [209.85.160.75])
        by gmr-mx.google.com with ESMTPS id r4si3974532paz.1.2012.11.05.06.37.57
        (version=TLSv1/SSLv3 cipher=OTHER);
        Mon, 05 Nov 2012 06:37:57 -0800 (PST)
Received-SPF: pass (google.com: domain of 3Rc-XUBAKBswu6vwA0Bw-569w73Gy66y3w.u64DQ-vwDy66y3wy96C7A....@codesite.bounces.google.com designates 209.85.160.75 as permitted sender) client-ip=209.85.160.75;
Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of 3Rc-XUBAKBswu6vwA0Bw-569w73Gy66y3w.u64DQ-vwDy66y3wy96C7A....@codesite.bounces.google.com designates 209.85.160.75 as permitted sender) smtp.mail=3Rc-XUBAKBswu6vwA0Bw-569w73Gy66y3w.u64DQ-vwDy66y3wy96C7A....@codesite.bounces.google.com; dkim=pass header...@google.com
Received: by mail-pb0-f75.google.com with SMTP id rp2so599199pbb.4
        for <v8-dev@googlegroups.com>; Mon, 05 Nov 2012 06:37:57 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=google.com; s=20120113;
        h=mime-version:x-generated-by:message-id:date:subject:from:to
         :content-type;
        bh=4BU4yKbqqToMH12UcxuiKIwdMYqn146c0zisjfTqlng=;
        b=Jt+GLn3RoM0jiKFaI8BUij7d5uPX+tnXvfAkL7i8mtfsnMFIYPYqhKsgzXoVx/Ppba
         YqV10D18+yRg5AvYhOruOvLv+7EAbWVrPoWnTXSUWbcqPk0vVmBXBg+rmLMxY5bdp6zo
         lsqqWLQaxvLHv78YjUD4a7U+AgWR9XM4fuFAnwh7mCXrJ1il/n9HeCIIvtjCZZuS/x1C
         iF5mUIHapnJe3Pbq88m3N3eagvTJ92bthZYzAt5vIC1e2re3DB4M1BRDQVNdvZ4r3H4U
         tjkFUkJvx9tz+Jm73UjuYob2MdYWjvO1WSRwPE/kKppsCXaBAfvCxPqWhsAvmszI2vWd
         zE6A==
MIME-Version: 1.0
Received: by 10.66.86.102 with SMTP id o6mr3645562paz.41.1352126277754; Mon,
 05 Nov 2012 06:37:57 -0800 (PST)
X-Generated-By: Google Code
Message-ID: <f46d042ef6ad7a1e1504cdc06...@google.com>
Date: Mon, 05 Nov 2012 14:37:57 +0000
Subject: [v8] r12856 committed - Nano-refactoring: Simplify initialization...
From: codesite-nore...@google.com
To: v8-dev@googlegroups.com
Content-Type: text/plain; charset=ISO-8859-1; format=flowed; delsp=yes

Revision: 12856
Author:   svenpa...@chromium.org
Date:     Mon Nov  5 06:37:28 2012
Log:      Nano-refactoring: Simplify initialization

Review URL: https://codereview.chromium.org/11368078
http://code.google.com/p/v8/source/detail?r=12856

Modified:
  /branches/bleeding_edge/src/hydrogen.cc

=======================================
--- /branches/bleeding_edge/src/hydrogen.cc	Mon Nov  5 05:28:10 2012
+++ /branches/bleeding_edge/src/hydrogen.cc	Mon Nov  5 06:37:28 2012
@@ -6348,7 +6348,6 @@

    HInstruction* elements_kind_instr =
        AddInstruction(new(zone()) HElementsKind(object));
-  HCompareConstantEqAndBranch* elements_kind_branch = NULL;
    HInstruction* elements =
        AddInstruction(new(zone()) HLoadElements(object, checkspec));
    HLoadExternalArrayPointer* external_elements = NULL;
@@ -6379,8 +6378,9 @@
      if (type_todo[elements_kind]) {
        HBasicBlock* if_true = graph()->CreateBasicBlock();
        HBasicBlock* if_false = graph()->CreateBasicBlock();
-      elements_kind_branch = new(zone()) HCompareConstantEqAndBranch(
-          elements_kind_instr, elements_kind, Token::EQ_STRICT);
+      HCompareConstantEqAndBranch* elements_kind_branch =
+          new(zone()) HCompareConstantEqAndBranch(
+              elements_kind_instr, elements_kind, Token::EQ_STRICT);
        elements_kind_branch->SetSuccessorAt(0, if_true);
        elements_kind_branch->SetSuccessorAt(1, if_false);
        current_block()->Finish(elements_kind_branch);