                                                                                                                                                                                                                                                                
Received-SPF: pass (google.com: domain of 3yNZuUBUJALkbgqnlhtlbncdqduhdv-gqflZhk....@2uix4h7xygsz66weerlq.apphosting.bounces.google.com designates 209.85.216.199 as permitted sender) client-ip=209.85.216.199;
MIME-Version: 1.0
Reply-To: rossb...@chromium.org, mstarzin...@chromium.org, 
	v8-dev@googlegroups.com
Message-ID: <047d7b6d7fced50d8d04cb4f4...@google.com>
Date: Fri, 05 Oct 2012 12:47:04 +0000
Subject: Re: Make sure that names of temporaries do not clash with real
 variables. (issue 11035054)
From: rossb...@chromium.org
To: mstarzin...@chromium.org
Cc: v8-dev@googlegroups.com
Content-Type: text/plain; charset=ISO-8859-1; format=flowed; delsp=yes


https://codereview.chromium.org/11035054/diff/1/src/parser.cc
File src/parser.cc (right):

https://codereview.chromium.org/11035054/diff/1/src/parser.cc#newcode2847
src/parser.cc:2847:
heap_factory->NewStringFromAscii(CStrVector(".for."));
On 2012/10/05 12:31:38, Michael Starzinger wrote:
> You could move this symbol into the root-set by adding it to
SYMBOL_LIST, call
> it e.g. dot_for_symbol and then access it through
factory->dot_for_symbol().

Done.

> Also does the name really need to be different for every temporary, or
could we
> use the one symbol for all temporaries?

There can be several loop variables in the same scope, so they should be
distinguishable.

https://codereview.chromium.org/11035054/