Received: by 10.58.132.145 with SMTP id ou17mr6118941veb.41.1352734549405;
        Mon, 12 Nov 2012 07:35:49 -0800 (PST)
X-BeenThere: v8-dev@googlegroups.com
Received: by 10.220.108.198 with SMTP id g6ls7748230vcp.1.gmail; Mon, 12 Nov
 2012 07:35:48 -0800 (PST)
Received: by 10.58.0.227 with SMTP id 3mr4282147veh.18.1352734548742;
        Mon, 12 Nov 2012 07:35:48 -0800 (PST)
Received: by 10.58.0.227 with SMTP id 3mr4282136veh.18.1352734548461;
        Mon, 12 Nov 2012 07:35:48 -0800 (PST)
Return-Path: <3UxehUBUJAJAw1B862E6w8xyByF2yG-1B06u25....@2uix4h7xygsz66weerlq.apphosting.bounces.google.com>
Received: from mail-vc0-f199.google.com (mail-vc0-f199.google.com [209.85.220.199])
        by gmr-mx.google.com with ESMTPS id dj17si2401406vdb.1.2012.11.12.07.35.47
        (version=TLSv1/SSLv3 cipher=OTHER);
        Mon, 12 Nov 2012 07:35:47 -0800 (PST)
Received-SPF: pass (google.com: domain of 3UxehUBUJAJAw1B862E6w8xyByF2yG-1B06u25....@2uix4h7xygsz66weerlq.apphosting.bounces.google.com designates 209.85.220.199 as permitted sender) client-ip=209.85.220.199;
Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of 3UxehUBUJAJAw1B862E6w8xyByF2yG-1B06u25....@2uix4h7xygsz66weerlq.apphosting.bounces.google.com designates 209.85.220.199 as permitted sender) smtp.mail=3UxehUBUJAJAw1B862E6w8xyByF2yG-1B06u25....@2uix4h7xygsz66weerlq.apphosting.bounces.google.com; dkim=pass header...@chromium.org
Received: by mail-vc0-f199.google.com with SMTP id gb23so11186850vcb.2
        for <v8-dev@googlegroups.com>; Mon, 12 Nov 2012 07:35:47 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=chromium.org; s=google;
        h=mime-version:reply-to:x-google-appengine-app-id:message-id:date
         :subject:from:to:cc:content-type;
        bh=k66/i5LHIra08C4r1mJ/X6yvCExXT2wvB43NQaF4JsU=;
        b=FhxGNRDzVW/2flDT4/n3vTlOcPXDrVsw0hCLDkWaD+NnPfrUMSUep7pIExbCSdic87
         RT+piEP8/pA4xZnZkac6F/QPp9iRvL3Jv6WTYSPmX8/vZRPZFtIZlBNxNBaV3UmZXi8+
         496THn5f4abtuCMhiwcF3R1l+UYB34Z5bUVrM=
MIME-Version: 1.0
Received: by 10.58.246.37 with SMTP id xt5mr6053051vec.13.1352734547065; Mon,
 12 Nov 2012 07:35:47 -0800 (PST)
Reply-To: remi.duraff...@st.com, jkumme...@chromium.org, 
	v8-dev@googlegroups.com
Message-ID: <047d7bea35d6273bd204ce4e0...@google.com>
Date: Mon, 12 Nov 2012 15:35:47 +0000
Subject: Re: First draft of the sh4 port (issue 11275184)
From: jkumme...@chromium.org
To: remi.duraff...@st.com
Cc: v8-dev@googlegroups.com
Content-Type: text/plain; charset=ISO-8859-1; format=flowed; delsp=yes

The platform-independent changes in patch set 2 look good.

I don't think anyone is planning to review the SH4-specific changes in  
detail,
as AFAIK nobody on the team knows the SH4 architecture well enough to spot  
any
mistakes.

The team has discussed this topic, and before we land SH4 support, it would  
be
nice to understand the motivation behind the port in order for us to be  
able to
decide to what extent we should support it.

Basically, there are two levels of support: there are the ports that  
Google's V8
team currently fully supports and maintains (ia32, x64, ARM), and  
there's "basic
support" (MIPS) where the code lives in our repository and we work with its
maintainers, e.g. by landing their patches and communicating with them about
issues or upcoming plans such as branch points or significant architectural
changes. We currently don't have any plans to extend the set of platforms  
in the
former group. For the latter to work, the platform port must be in a shape  
where
it fits into our infrastructure and workflow: we must at least be able to
compile it and run the test suite, which means it must have a simulator and  
the
test expectations must be up to date so that the test suite passes. We're  
not
willing to introduce dependencies on third-party tools for this, e.g. QEmu.

Before you reach the "basic support" stage, an option that could work quite  
well
for you is to have a github clone of V8 that tracks our mirror. That way  
you'll
be on top of the latest sources and can iterate on your port with minimal
latency.

Once you have all of the code in place (simulator, anything missing to make  
the
majority of the tests work, expectation file for the others), we will  
review the
style and general structure of the SH4 specific code. This may take a few  
weeks.
To be clear, once the patch is approved, we will land it into the V8 tree,  
but
it will continue to be your responsibility to make sure it keeps working and
stays up to date, and we reserve the right to remove the port at a future  
date
if you are no longer able to maintain it.

https://codereview.chromium.org/11275184/