Account Options

  1. Sign in
The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Google Groups Home
« Groups Home
v8-dev
Home
+ new post
About this group
Join this group
Message from discussion Correctly visit all external strings. (issue 11340010)
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
 
From:
To:
Cc:
Followup To:
Add Cc | Add Followup-to | Edit Subject
Subject:
Validation:
For verification purposes please type the characters you see in the picture below or the numbers you hear by clicking the accessibility icon. Listen and type the numbers you hear
 
erikco...@google.com  
View profile  
 More options Nov 2 2012, 8:02 am
From: erikco...@google.com
Date: Fri, 02 Nov 2012 12:02:58 +0000
Local: Fri, Nov 2 2012 8:02 am
Subject: Re: Correctly visit all external strings. (issue 11340010)
Print | View thread | Show original | Report this message | Find messages by this author
LGTM

https://chromiumcodereview.appspot.com/11340010/diff/1/src/heap.cc
File src/heap.cc (right):

https://chromiumcodereview.appspot.com/11340010/diff/1/src/heap.cc#ne...
src/heap.cc:1601: } external_string_table_visitor(visitor);
Please add a blank line here between the class definition and the
invocation of Iterate, so it stands out more.  Or you could move it down
to the other invocation

https://chromiumcodereview.appspot.com/11340010/diff/1/src/heap.cc#ne...
src/heap.cc:1619: } symbol_table_visitor(visitor);
Blank line here please.

https://chromiumcodereview.appspot.com/11340010/


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Create a group - Google Groups - Google Home - Terms of Service - Privacy Policy
©2013 Google