Message from discussion
Clarify that date parsing follows Safari. (issue 11085006)
Received: by 10.58.18.172 with SMTP id x12mr2070295ved.38.1349697528895;
Mon, 08 Oct 2012 04:58:48 -0700 (PDT)
X-BeenThere: v8-dev@googlegroups.com
Received: by 10.52.21.40 with SMTP id s8ls4282071vde.8.gmail; Mon, 08 Oct 2012
04:58:48 -0700 (PDT)
Received: by 10.58.221.132 with SMTP id qe4mr2412942vec.9.1349697528319;
Mon, 08 Oct 2012 04:58:48 -0700 (PDT)
Received: by 10.58.221.132 with SMTP id qe4mr2412941vec.9.1349697528309;
Mon, 08 Oct 2012 04:58:48 -0700 (PDT)
Return-Path: <3979yUBUJAMosx742yA2s4tu7uByuC-x7w2qy1....@2uix4h7xygsz66weerlq.apphosting.bounces.google.com>
Received: from mail-vb0-f72.google.com (mail-vb0-f72.google.com [209.85.212.72])
by gmr-mx.google.com with ESMTPS id bn19si1019030vdb.0.2012.10.08.04.58.47
(version=TLSv1/SSLv3 cipher=OTHER);
Mon, 08 Oct 2012 04:58:47 -0700 (PDT)
Received-SPF: pass (google.com: domain of 3979yUBUJAMosx742yA2s4tu7uByuC-x7w2qy1....@2uix4h7xygsz66weerlq.apphosting.bounces.google.com designates 209.85.212.72 as permitted sender) client-ip=209.85.212.72;
Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of 3979yUBUJAMosx742yA2s4tu7uByuC-x7w2qy1....@2uix4h7xygsz66weerlq.apphosting.bounces.google.com designates 209.85.212.72 as permitted sender) smtp.mail=3979yUBUJAMosx742yA2s4tu7uByuC-x7w2qy1....@2uix4h7xygsz66weerlq.apphosting.bounces.google.com; dkim=pass header...@chromium.org
Received: by mail-vb0-f72.google.com with SMTP id fa15so6245806vbb.3
for <v8-dev@googlegroups.com>; Mon, 08 Oct 2012 04:58:47 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=chromium.org; s=google;
h=mime-version:reply-to:x-google-appengine-app-id:message-id:date
:subject:from:to:cc:content-type;
bh=xKOEKq4w6xvb7CAOKBi3a64GbihSKVvBQDT2cubrdxQ=;
b=Fdziy7bZh6nzX6DgGJwUr9runxUHeMfckUoLFUxuKcgDt4LGj2/hPgaDMGaG/woatl
Uzzsm/RE1ajeGv0oZRiabYlxNwdAcqX+JwZ0I8yupfWl3ksVm4Z2SQ14UwlRVnUWvaH4
2aKHKWSxrwN6KJG2rdJYlHIyb11VZccPQXfU4=
d=google.com; s=20120113;
h=mime-version:reply-to:x-google-appengine-app-id:message-id:date
:subject:from:to:cc:content-type:x-gm-message-state;
bh=xKOEKq4w6xvb7CAOKBi3a64GbihSKVvBQDT2cubrdxQ=;
b=bU7ZSz9OuWYaOnUz4aFeHOK8ZI3B+JXg1Mrx+50lrh+O6893aARbt2OrXJUJtZU9Aj
BthEsU63Ix7nHTZcVf/zU9dUkFgvAP6qOrBUWJiIpgJ4WI13cc5qQU+X51s74NI7A0Wj
XIh8sbleMrJZyEYGq2lnza0Au1a7X6VZU8Dshc4X0r7emqeAaf+RSO2+B4kg1W5ld7vf
f88ARUEhyHOhpHH4OOWUrUs2AjA5W4siF66EtN/H572axIUbpyTgIeQ16qod4GEQv5NW
s836h7wwwc0lpuY8OL5Rlz0tOpDThptqrlJQPjgw0ZiZ+0JKAi7tm/O9QC2aFPCSt9hX
g5Bg==
MIME-Version: 1.0
Received: by 10.58.19.136 with SMTP id f8mr4429115vee.18.1349697527167; Mon,
08 Oct 2012 04:58:47 -0700 (PDT)
Reply-To: rossb...@chromium.org, u...@chromium.org, v8-dev@googlegroups.com
Message-ID: <047d7b86ec00a93aa004cb8af...@google.com>
Date: Mon, 08 Oct 2012 11:58:47 +0000
Subject: Clarify that date parsing follows Safari. (issue 11085006)
From: rossb...@chromium.org
To: u...@chromium.org
Cc: v8-dev@googlegroups.com
Content-Type: text/plain; charset=ISO-8859-1; format=flowed; delsp=yes
X-Gm-Message-State: ALoCoQkpT2Dcc2ImU8Dzs4JEQb534MPmqSxJtEmYnCczUGgj22A1L3phsHKEiPqDL6wkrqJ5xcBH
Reviewers: ulan,
Description:
Clarify that date parsing follows Safari.
R=u...@chromium.org
BUG=145198
Please review this at https://codereview.chromium.org/11085006/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/dateparser-inl.h
Index: src/dateparser-inl.h
diff --git a/src/dateparser-inl.h b/src/dateparser-inl.h
index
a5c7143bdd37743a0b334696ec6e83ecd181b96e..3cb36fa433998e96dbb9acadae999a791cc89277
100644
--- a/src/dateparser-inl.h
+++ b/src/dateparser-inl.h
@@ -62,7 +62,8 @@ bool DateParser::Parse(Vector<Char> str,
// sss is in the range 000..999,
// hh is in the range 00..23,
// mm, ss, and sss default to 00 if missing, and
- // timezone defaults to Z if missing.
+ // timezone defaults to Z if missing
+ // (following Safari, ISO actually demands local time).
// Extensions:
// We also allow sss to have more or less than three digits (but at
// least one).