Re: Add a faster API for creating v8::Integer objects (issue 11212004)

[da...@chromium.org]

If you are going to go through all this trouble to optimize for the
isolate, you
probably should make these inlined for the fast case of looking up a 31-bit
signed integer. If you inline that case and then fall back to api.cc only
when
you need to allocate a heap number. If you do that, I suspect that it will
as
fast as the integer cache, unless webkit often caches integers where the
than
don't fit in the 31-bit signed range.





https://codereview.chromium.org/11212004/

[aba...@chromium.org]

I wanted to do that, but I wasn't sure how. I couldn't figure out how to
call
i::Smi::IsValid and i::Smi::FromInt from the header. Should I just do the
bit
mashing manually or is there a more structured approach I should use in the
header?

Thanks for the review!

https://codereview.chromium.org/11212004/

[da...@chromium.org]

Actually, I don't know if you will ever be able to replace the int cache
with
this code, since it allocates handles. Even if it's inlined, the handle
allocation will probably make it more than trivially expensive.

I'll land this in its current form which LGTM. At some point, mstarzinger or
svenpanne might want to make it inlinable, but that won't change the API.

https://codereview.chromium.org/11212004/