                                                                                                                                                                                                                                                                
Received-SPF: pass (google.com: domain of 3CtxqUBUJAPUZeoljfrjZlabobsfbt-eodjXfi....@2uix4h7xygsz66weerlq.apphosting.bounces.google.com designates 209.85.216.200 as permitted sender) client-ip=209.85.216.200;
MIME-Version: 1.0
Reply-To: u...@chromium.org, da...@chromium.org, mstarzin...@chromium.org, 
	dcon...@codeaurora.org, v8-dev@googlegroups.com
Message-ID: <047d7bf0ea800e022e04cb128...@google.com>
Date: Tue, 02 Oct 2012 12:20:26 +0000
Subject: Re: Add rotate-right instruction to hydrogen and use it instead of
 bitwise operations (issue 11033005)
From: u...@chromium.org
To: da...@chromium.org, mstarzin...@chromium.org, dcon...@codeaurora.org
Cc: v8-dev@googlegroups.com
Content-Type: text/plain; charset=ISO-8859-1; format=flowed; delsp=yes

I uploaded a new patch set that addresses the comments and fixes a
representation bug.


http://codereview.chromium.org/11033005/diff/2001/src/arm/simulator-arm.cc
File src/arm/simulator-arm.cc (right):

http://codereview.chromium.org/11033005/diff/2001/src/arm/simulator-arm.cc#newcode1503
src/arm/simulator-arm.cc:1503: } else {
On 2012/10/01 19:41:17, Jay Conrod wrote:
> Erik Corry expressed some suspicion in my first rev about the shifts,
and I
> agree. "result" is signed (int32_t), so >> will sign extend. Also
*carry_out
> should contain the last bit that was shifted, so it can be
> (static_cast<uint32_t>(result) >> 31) != 0, right?

Yes, you're right. I am taking the updated implementation that you
uploaded in the other CL.

http://codereview.chromium.org/11033005/