Account Options

  1. Sign in
The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Google Groups Home
« Groups Home
v8-dev
Home
+ new post
About this group
Join this group
Object.observe: Handle oldValue for elements with accessors properly. (issue 11358234)
Options
There are currently too many topics in this group that display first. To make this topic appear first, remove this option from another topic.
There was an error processing your request. Please try again.
flag
   4 messages - Collapse all  -  Translate all to Translated (View all originals)
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
 
From:
To:
Cc:
Followup To:
Add Cc | Add Followup-to | Edit Subject
Subject:
Validation:
For verification purposes please type the characters you see in the picture below or the numbers you hear by clicking the accessibility icon. Listen and type the numbers you hear
 
rossb...@chromium.org  
View profile  
 More options Nov 14 2012, 11:10 am
From: rossb...@chromium.org
Date: Wed, 14 Nov 2012 16:10:42 +0000
Local: Wed, Nov 14 2012 11:10 am
Subject: Object.observe: Handle oldValue for elements with accessors properly. (issue 11358234)
Print | Individual message | Show original | Report this message | Find messages by this author
Reviewers: Michael Starzinger,

Description:
Object.observe: Handle oldValue for elements with accessors properly.

Extended ElementAccessor interface to allow querying PropertyType and
AccessorPair. Also added respective functionality to JSObject.

R=mstarzin...@chromium.org
BUG=

Please review this at https://codereview.chromium.org/11358234/

SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge

Affected files:
   M src/elements.h
   M src/elements.cc
   M src/objects.h
   M src/objects.cc
   M src/runtime.cc
   M test/mjsunit/harmony/object-observe.js


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
mstarzin...@chromium.org  
View profile  
 More options Nov 14 2012, 12:30 pm
From: mstarzin...@chromium.org
Date: Wed, 14 Nov 2012 17:30:39 +0000
Local: Wed, Nov 14 2012 12:30 pm
Subject: Re: Object.observe: Handle oldValue for elements with accessors properly. (issue 11358234)
Print | Individual message | Show original | Report this message | Find messages by this author
LGTM with two comments.

https://codereview.chromium.org/11358234/diff/1/src/elements.cc
File src/elements.cc (right):

https://codereview.chromium.org/11358234/diff/1/src/elements.cc#newco...
src/elements.cc:1551: return
AccessorPair::cast(backing_store->ValueAt(entry));
This could potentially also be a Foreign callback or a AccessorInfo
callback. I am unsure if that ever happens in any of our embedders, so
we could just add a CHECK (on top of the implicit assertion) here that
the value we get out actually is a AccessorPair. WDYT?

https://codereview.chromium.org/11358234/diff/1/src/objects.h
File src/objects.h (right):

https://codereview.chromium.org/11358234/diff/1/src/objects.h#newcode...
src/objects.h:1844: enum LocalElementKind {
As discussed offline, we should try to get rid of this enum completely.
But until then I am fine with the new name.

https://codereview.chromium.org/11358234/


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
svenpa...@chromium.org  
View profile  
 More options Nov 15 2012, 1:36 am
From: svenpa...@chromium.org
Date: Thu, 15 Nov 2012 06:36:32 +0000
Local: Thurs, Nov 15 2012 1:36 am
Subject: Re: Object.observe: Handle oldValue for elements with accessors properly. (issue 11358234)
Print | Individual message | Show original | Report this message | Find messages by this author

https://codereview.chromium.org/11358234/diff/1/src/elements.cc
File src/elements.cc (right):

https://codereview.chromium.org/11358234/diff/1/src/elements.cc#newco...
src/elements.cc:1551: return
AccessorPair::cast(backing_store->ValueAt(entry));
On 2012/11/14 17:30:39, Michael Starzinger wrote:

> This could potentially also be a Foreign callback or a AccessorInfo
callback. I
> am unsure if that ever happens in any of our embedders, so we could
just add a
> CHECK (on top of the implicit assertion) here that the value we get
out actually
> is a AccessorPair. WDYT?

The Foreign case is completely under our control and (very probably)
doesn't matter here, but the unhandled AccessorInfo case really makes me
nervous: If I understand things correctly, this would change our
external API with unknown consequences. I would very much prefer
avoiding this. If there is really, really no way around this, the
restriction (which one exactly?) should be documented in a very visible
way in our external header.

https://codereview.chromium.org/11358234/


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
rossb...@chromium.org  
View profile  
 More options Nov 15 2012, 6:25 am
From: rossb...@chromium.org
Date: Thu, 15 Nov 2012 11:25:43 +0000
Local: Thurs, Nov 15 2012 6:25 am
Subject: Re: Object.observe: Handle oldValue for elements with accessors properly. (issue 11358234)
Print | Individual message | Show original | Report this message | Find messages by this author

https://codereview.chromium.org/11358234/diff/1/src/elements.cc
File src/elements.cc (right):

https://codereview.chromium.org/11358234/diff/1/src/elements.cc#newco...
src/elements.cc:1551: return
AccessorPair::cast(backing_store->ValueAt(entry));
On 2012/11/15 06:36:32, Sven Panne wrote:

That was an oversight. Added IsAccessorPair condition, returning NULL
otherwise (analogous to JSObject::GetLocalPropertyAccessorPair).

https://codereview.chromium.org/11358234/


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
End of messages
« Back to Discussions « Newer topic     Older topic »

Create a group - Google Groups - Google Home - Terms of Service - Privacy Policy
©2013 Google