Account Options

  1. Sign in
The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Google Groups Home
« Groups Home
Change the Android makefile to use GCC 4.6 instead of GCC 4.4.3. (issue 11032018)
There are currently too many topics in this group that display first. To make this topic appear first, remove this option from another topic.
There was an error processing your request. Please try again.
flag
  2 messages - Collapse all  -  Translate all to Translated (View all originals)
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
 
From:
To:
Cc:
Followup To:
Add Cc | Add Followup-to | Edit Subject
Subject:
Validation:
For verification purposes please type the characters you see in the picture below or the numbers you hear by clicking the accessibility icon. Listen and type the numbers you hear
 
u...@chromium.org  
View profile  
 More options Oct 2 2012, 9:10 am
From: u...@chromium.org
Date: Tue, 02 Oct 2012 13:10:35 +0000
Local: Tues, Oct 2 2012 9:10 am
Subject: Change the Android makefile to use GCC 4.6 instead of GCC 4.4.3. (issue 11032018)
Reviewers: Jakob,

Message:
PTAL

Description:
Change the Android makefile to use GCC 4.6 instead of GCC 4.4.3.

Android NDK 8b includes GCC 4.6

R=jkumme...@chromium.org

Please review this at https://chromiumcodereview.appspot.com/11032018/

SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge

Affected files:
   M Makefile.android

Index: Makefile.android
diff --git a/Makefile.android b/Makefile.android
index  
a8d7fe148e4e7c2d498cd6316b5c71f5d6c96e1e..8e4ce0814ab6835dd59f4b55795f9a82c fef5f45  
100644
--- a/Makefile.android
+++ b/Makefile.android
@@ -48,11 +48,11 @@ endif
  ifeq ($(ARCH), android_arm)
    DEFINES  = target_arch=arm v8_target_arch=arm android_target_arch=arm
    DEFINES += arm_neon=0 armv7=1
-  TOOLCHAIN_ARCH = arm-linux-androideabi-4.4.3
+  TOOLCHAIN_ARCH = arm-linux-androideabi-4.6
  else
    ifeq ($(ARCH), android_ia32)
      DEFINES = target_arch=ia32 v8_target_arch=ia32 android_target_arch=x86
-    TOOLCHAIN_ARCH = x86-4.4.3
+    TOOLCHAIN_ARCH = x86-4.6
    else
      $(error Target architecture "${ARCH}" is not supported)
    endif


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
jkumme...@chromium.org  
View profile  
 More options Oct 2 2012, 9:14 am
From: jkumme...@chromium.org
Date: Tue, 02 Oct 2012 13:14:31 +0000
Local: Tues, Oct 2 2012 9:14 am
Subject: Re: Change the Android makefile to use GCC 4.6 instead of GCC 4.4.3. (issue 11032018)
LGTM.

Please also update the wiki page to reflect the new NDK requirements.

https://chromiumcodereview.appspot.com/11032018/


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
End of messages
« Back to Discussions « Newer topic     Older topic »