Fix GDBJIT to respect v8_enable_gdbjit GYP flag. (issue 11195043)

4 views
Skip to first unread message

ul...@chromium.org

unread,
Oct 18, 2012, 11:00:13 AM10/18/12
to jkum...@chromium.org, v8-...@googlegroups.com
Reviewers: Jakob,

Message:
PTAL

Description:
Fix GDBJIT to respect v8_enable_gdbjit GYP flag.

R=jkum...@chromium.org


Please review this at https://chromiumcodereview.appspot.com/11195043/

SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge

Affected files:
M build/common.gypi


Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index
dc5456bb21d47f91b759a77d54383ce154874bd4..5b2b668420ec4879b8dbab33261d736c2b5a2a99
100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -357,7 +357,11 @@
['OS=="linux" or OS=="freebsd" or OS=="openbsd" or
OS=="netbsd"', {
'cflags':
[ '-Wall', '<(werror)', '-W', '-Wno-unused-parameter',
'-Wnon-virtual-dtor', '-Woverloaded-virtual' ],
- 'defines': ['ENABLE_GDB_JIT_INTERFACE',],
+ 'conditions': [
+ ['v8_enable_gdbjit==1', {
+ 'defines': ['ENABLE_GDB_JIT_INTERFACE',],
+ }],
+ ],
}],
['OS=="android"', {
'variables': {


jkum...@chromium.org

unread,
Oct 18, 2012, 11:24:13 AM10/18/12
to ul...@chromium.org, v8-...@googlegroups.com
Reply all
Reply to author
Forward
0 new messages