Account Options

  1. Sign in
The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Google Groups Home
« Groups Home
v8-dev
Home
+ new post
About this group
Join this group
Prepare for using GYP build on buildbots (issue 10383128)
Options
There are currently too many topics in this group that display first. To make this topic appear first, remove this option from another topic.
There was an error processing your request. Please try again.
flag
   3 messages - Collapse all  -  Translate all to Translated (View all originals)
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
 
From:
To:
Cc:
Followup To:
Add Cc | Add Followup-to | Edit Subject
Subject:
Validation:
For verification purposes please type the characters you see in the picture below or the numbers you hear by clicking the accessibility icon. Listen and type the numbers you hear
 
jkumme...@chromium.org  
View profile  
 More options May 11 2012, 6:29 am
From: jkumme...@chromium.org
Date: Fri, 11 May 2012 10:29:26 +0000
Local: Fri, May 11 2012 6:29 am
Subject: Prepare for using GYP build on buildbots (issue 10383128)
Print | Individual message | Show original | Report this message | Find messages by this author
Reviewers: Yang,

Message:
Please take a look.

Happy to explain/discuss any of the changes.

Description:
Prepare for using GYP build on buildbots

Please review this at https://chromiumcodereview.appspot.com/10383128/

SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge

Affected files:
   A DEPS
   M Makefile
   M SConstruct
   M build/common.gypi
   M build/gyp_v8
   M build/standalone.gypi
   M test/cctest/testcfg.py
   M test/mjsunit/big-array-literal.js
   M test/test262/testcfg.py
   M tools/check-static-initializers.sh
   M tools/presubmit.py
   M tools/test-wrapper-gypbuild.py


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
yang...@chromium.org  
View profile  
 More options May 11 2012, 8:07 am
From: yang...@chromium.org
Date: Fri, 11 May 2012 12:07:00 +0000
Subject: Re: Prepare for using GYP build on buildbots (issue 10383128)
Print | Individual message | Show original | Report this message | Find messages by this author
LGTM with two comments.

https://chromiumcodereview.appspot.com/10383128/diff/1/DEPS
File DEPS (right):

https://chromiumcodereview.appspot.com/10383128/diff/1/DEPS#newcode27
DEPS:27: ]
Make sure the commit doesn't include the following lines.

https://chromiumcodereview.appspot.com/10383128/diff/1/test/test262/t...
File test/test262/testcfg.py (right):

https://chromiumcodereview.appspot.com/10383128/diff/1/test/test262/t...
test/test262/testcfg.py:125: archive.extractall(u'\\\\?\\%s' %
self.root)
Maybe add a comment here.

https://chromiumcodereview.appspot.com/10383128/


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
jkumme...@chromium.org  
View profile  
 More options May 11 2012, 8:17 am
From: jkumme...@chromium.org
Date: Fri, 11 May 2012 12:17:01 +0000
Local: Fri, May 11 2012 8:17 am
Subject: Re: Prepare for using GYP build on buildbots (issue 10383128)
Print | Individual message | Show original | Report this message | Find messages by this author

https://chromiumcodereview.appspot.com/10383128/diff/1/DEPS
File DEPS (right):

https://chromiumcodereview.appspot.com/10383128/diff/1/DEPS#newcode27
DEPS:27: ]
On 2012/05/11 12:07:00, Yang wrote:

> Make sure the commit doesn't include the following lines.

Done.

https://chromiumcodereview.appspot.com/10383128/diff/1/test/test262/t...
File test/test262/testcfg.py (right):

https://chromiumcodereview.appspot.com/10383128/diff/1/test/test262/t...
test/test262/testcfg.py:125: archive.extractall(u'\\\\?\\%s' %
self.root)
On 2012/05/11 12:07:00, Yang wrote:

> Maybe add a comment here.

Done.

https://chromiumcodereview.appspot.com/10383128/


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
End of messages
« Back to Discussions « Newer topic     Older topic »

Create a group - Google Groups - Google Home - Terms of Service - Privacy Policy
©2013 Google