Account Options

  1. Sign in
The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Google Groups Home
« Groups Home
v8-dev
Home
+ new post
About this group
Join this group
Fix register confusion in non-VFP3 BinaryOpStubs on ARM (issue 11413014)
Options
There are currently too many topics in this group that display first. To make this topic appear first, remove this option from another topic.
There was an error processing your request. Please try again.
flag
   2 messages - Collapse all  -  Translate all to Translated (View all originals)
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
 
From:
To:
Cc:
Followup To:
Add Cc | Add Followup-to | Edit Subject
Subject:
Validation:
For verification purposes please type the characters you see in the picture below or the numbers you hear by clicking the accessibility icon. Listen and type the numbers you hear
 
jkumme...@chromium.org  
View profile  
 More options Nov 15 2012, 12:28 pm
From: jkumme...@chromium.org
Date: Thu, 15 Nov 2012 17:28:42 +0000
Local: Thurs, Nov 15 2012 12:28 pm
Subject: Fix register confusion in non-VFP3 BinaryOpStubs on ARM (issue 11413014)
Print | Individual message | Show original | Report this message | Find messages by this author
Reviewers: Yang,

Message:
PTAL.

Most of the changes are simple renamings to increase sanity levels; but  
there
are also no less than four real bug fixes :-)

https://codereview.chromium.org/11413014/diff/1/src/arm/code-stubs-ar...
File src/arm/code-stubs-arm.cc (right):

https://codereview.chromium.org/11413014/diff/1/src/arm/code-stubs-ar...
src/arm/code-stubs-arm.cc:870: __ bic(scratch1, dst_exponent,
Operand(HeapNumber::kSignMask));
Bug fix 1: This code cleared the mantissa's sign bit!

https://codereview.chromium.org/11413014/diff/1/src/arm/code-stubs-ar...
src/arm/code-stubs-arm.cc:878: DoubleIs32BitInteger(masm, dst_exponent,
dst_mantissa, scratch1, scratch2,
Bug fix 2: This call passed in the exponent/mantissa registers in the
wrong order.

https://codereview.chromium.org/11413014/diff/1/src/arm/code-stubs-ar...
src/arm/code-stubs-arm.cc:883: __ Pop(dst_exponent, dst_mantissa);
Bug fix 3: Restore the "object" register before reloading the double
value from it.

https://codereview.chromium.org/11413014/diff/1/src/arm/code-stubs-ar...
src/arm/code-stubs-arm.cc:891: __ Pop(dst_exponent, dst_mantissa);
Bug fix 4: Restore original inputs before calling the runtime.

Description:
Fix register confusion in non-VFP3 BinaryOpStubs on ARM

Please review this at https://codereview.chromium.org/11413014/

SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge

Affected files:
   M src/arm/code-stubs-arm.cc
   M src/arm/stub-cache-arm.cc


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
yang...@chromium.org  
View profile  
 More options Nov 16 2012, 3:50 am
From: yang...@chromium.org
Date: Fri, 16 Nov 2012 08:50:09 +0000
Local: Fri, Nov 16 2012 3:50 am
Subject: Re: Fix register confusion in non-VFP3 BinaryOpStubs on ARM (issue 11413014)
Print | Individual message | Show original | Report this message | Find messages by this author
On 2012/11/15 17:28:42, Jakob wrote:

> PTAL.
> Most of the changes are simple renamings to increase sanity levels; but  
> there
> are also no less than four real bug fixes :-)
> https://codereview.chromium.org/11413014/diff/1/src/arm/code-stubs-ar...
> File src/arm/code-stubs-arm.cc (right):

https://codereview.chromium.org/11413014/diff/1/src/arm/code-stubs-ar...

> src/arm/code-stubs-arm.cc:870: __ bic(scratch1, dst_exponent,
> Operand(HeapNumber::kSignMask));
> Bug fix 1: This code cleared the mantissa's sign bit!

https://codereview.chromium.org/11413014/diff/1/src/arm/code-stubs-ar...

> src/arm/code-stubs-arm.cc:878: DoubleIs32BitInteger(masm, dst_exponent,
> dst_mantissa, scratch1, scratch2,
> Bug fix 2: This call passed in the exponent/mantissa registers in the  
> wrong
> order.

https://codereview.chromium.org/11413014/diff/1/src/arm/code-stubs-ar...

> src/arm/code-stubs-arm.cc:883: __ Pop(dst_exponent, dst_mantissa);
> Bug fix 3: Restore the "object" register before reloading the double value
from
> it.

https://codereview.chromium.org/11413014/diff/1/src/arm/code-stubs-ar...

> src/arm/code-stubs-arm.cc:891: __ Pop(dst_exponent, dst_mantissa);
> Bug fix 4: Restore original inputs before calling the runtime.

LGTM. Nice catch!

https://codereview.chromium.org/11413014/


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
End of messages
« Back to Discussions « Newer topic     Older topic »

Create a group - Google Groups - Google Home - Terms of Service - Privacy Policy
©2013 Google