Account Options

  1. Sign in
The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Google Groups Home
« Groups Home
v8-dev
Home
+ new post
About this group
Join this group
r12940 committed - Fix details in message formatting....
Options
There are currently too many topics in this group that display first. To make this topic appear first, remove this option from another topic.
There was an error processing your request. Please try again.
flag
   1 message - Collapse all  -  Translate all to Translated (View all originals)
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
 
From:
To:
Cc:
Followup To:
Add Cc | Add Followup-to | Edit Subject
Subject:
Validation:
For verification purposes please type the characters you see in the picture below or the numbers you hear by clicking the accessibility icon. Listen and type the numbers you hear
 
codesite-nore...@google.com  
View profile  
 More options Nov 13 2012, 4:02 am
From: codesite-nore...@google.com
Date: Tue, 13 Nov 2012 09:02:07 +0000
Local: Tues, Nov 13 2012 4:02 am
Subject: [v8] r12940 committed - Fix details in message formatting....
Print | Individual message | Show original | Report this message | Find messages by this author
Revision: 12940
Author:   yang...@chromium.org
Date:     Tue Nov 13 01:01:43 2012
Log:      Fix details in message formatting.

BUG=

Review URL: https://chromiumcodereview.appspot.com/11360220
http://code.google.com/p/v8/source/detail?r=12940

Modified:
  /branches/bleeding_edge/src/isolate.cc
  /branches/bleeding_edge/src/messages.js

=======================================
--- /branches/bleeding_edge/src/isolate.cc      Mon Nov 12 09:32:30 2012
+++ /branches/bleeding_edge/src/isolate.cc      Tue Nov 13 01:01:43 2012
@@ -1235,7 +1235,7 @@
        // exception object to be set later must not be turned into a string.
        if (exception_arg->IsJSObject() && !IsErrorObject(exception_arg)) {
          bool failed = false;
-        exception_arg = Execution::ToString(exception_arg, &failed);
+        exception_arg = Execution::ToDetailString(exception_arg, &failed);
          if (failed) {
            exception_arg = factory()->LookupAsciiSymbol("exception");
          }
=======================================
--- /branches/bleeding_edge/src/messages.js     Mon Nov 12 06:54:29 2012
+++ /branches/bleeding_edge/src/messages.js     Tue Nov 13 01:01:43 2012
@@ -190,6 +190,7 @@
    if (IS_BOOLEAN(obj)) return x ? 'true' : 'false';
    if (IS_UNDEFINED(obj)) return 'undefined';
    if (IS_NULL(obj)) return 'null';
+  if (IS_FUNCTION(obj)) return  %_CallFunction(obj, FunctionToString);
    if (IS_OBJECT(obj) && %GetDataProperty(obj, "toString") ===  
ObjectToString) {
      var constructor = obj.constructor;
      if (typeof constructor == "function") {


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
End of messages
« Back to Discussions « Newer topic     Older topic »

Create a group - Google Groups - Google Home - Terms of Service - Privacy Policy
©2013 Google