Flag optimize-constructed-arrays turned on. (issue 14616010)

1 view
Skip to first unread message

mvst...@chromium.org

unread,
Apr 30, 2013, 3:55:51 AM4/30/13
to da...@chromium.org, v8-...@googlegroups.com
Reviewers: danno,

Message:
Hi Danno,
Here is the CL we discussed, thanks for having a look!
--Michael


Description:
Flag optimize-constructed-arrays turned on.

This routes array construction through a hydrogen stub, and enables use of
allocation site info tracking.

BUG=

Please review this at https://codereview.chromium.org/14616010/

SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge

Affected files:
M src/flag-definitions.h
M test/mjsunit/allocation-site-info.js


Index: src/flag-definitions.h
diff --git a/src/flag-definitions.h b/src/flag-definitions.h
index
1e454ff5468bad257ba46adf110216425086fe4d..168ae5161d4c546fc28e957a9ac1b5c45a853781
100644
--- a/src/flag-definitions.h
+++ b/src/flag-definitions.h
@@ -252,7 +252,7 @@ DEFINE_bool(unreachable_code_elimination, false,
"eliminate unreachable code (hidden behind soft deopts)")
DEFINE_bool(track_allocation_sites, true,
"Use allocation site info to reduce transitions")
-DEFINE_bool(optimize_constructed_arrays, false,
+DEFINE_bool(optimize_constructed_arrays, true,
"Use allocation site info on constructed arrays")
DEFINE_bool(trace_osr, false, "trace on-stack replacement")
DEFINE_int(stress_runs, 0, "number of stress runs")
Index: test/mjsunit/allocation-site-info.js
diff --git a/test/mjsunit/allocation-site-info.js
b/test/mjsunit/allocation-site-info.js
index
d85ce3ef533a3743b99373e536588e8c9e595fa9..0baeff64ead6cd542d438fa644e01027e1395a72
100644
--- a/test/mjsunit/allocation-site-info.js
+++ b/test/mjsunit/allocation-site-info.js
@@ -41,7 +41,7 @@

// support_smi_only_arrays = %HasFastSmiElements(new
Array(1,2,3,4,5,6,7,8));
support_smi_only_arrays = true;
-optimize_constructed_arrays = false;
+optimize_constructed_arrays = true;

if (support_smi_only_arrays) {
print("Tests include smi-only arrays.");


da...@chromium.org

unread,
Apr 30, 2013, 4:21:01 AM4/30/13
to mvst...@chromium.org, v8-...@googlegroups.com

mvst...@chromium.org

unread,
Apr 30, 2013, 4:22:12 AM4/30/13
to da...@chromium.org, v8-...@googlegroups.com
Committed patchset #1 manually as r14490 (presubmit successful).

https://codereview.chromium.org/14616010/
Reply all
Reply to author
Forward
0 new messages