Added automatic debug break for processing debugger commands

0 views
Skip to first unread message

sgj...@chromium.org

unread,
Mar 13, 2009, 9:07:17 AM3/13/09
to ag...@chromium.org, v8-...@googlegroups.com
Reviewers: Mads Ager,

Description:
A new stack guard break flag DEBUGCOMMAND has been introduced. This is
used to signal debug break due to debugger commands available in the
queue for processing. If a stack guard break happens with this flag and
not the DEBUGBREAK flag the no debug break event is generated and
execution is resumed automatically when all debugger commands in the
queue has been processed.

This makes it possible to remote debuggers to just add commands to the
queue without having to request a break as well. As soon as any
JavaScript executes the debugger commands will be processed and the
response send to the remote debugger.

Currently hide this behind a flag (--debugger-auto-break) as the current
command line debugger in Chrome is not designed for this new behaviour,
whereas the new Chrome developer tools will use it.

Please review this at http://codereview.chromium.org/42173

SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/

Affected files:
M src/debug.h
M src/debug.cc
M src/execution.h
M src/execution.cc
M src/flag-definitions.h
M test/cctest/test-debug.cc


ag...@chromium.org

unread,
Mar 13, 2009, 9:14:57 AM3/13/09
to sgj...@chromium.org, v8-...@googlegroups.com
Reply all
Reply to author
Forward
0 new messages