Inlining a few virtual frame functions.... (issue660104)

[fschn...@chromium.org]

Reviewers: Søren Gjesse,

Message:
It looks a lot, but is really only refactoring, cleanup of includes and
declaring some small functions in the virtual frame and the code generator
as
inline.


Description:
Inlining a few virtual frame functions.

Introducing a virtual-frame-inl.h file containing some platform-independent
virtual frame function which are small enough to be inlined.

Removed unnecessary #include of virtual-frame.h from
register-allocator-inl.h
and added the necessary explicit includes in a number of files.


Please review this at http://codereview.chromium.org/660104

SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/

Affected files:
M src/arm/codegen-arm.h
M src/arm/codegen-arm.cc
M src/arm/fast-codegen-arm.cc
M src/arm/full-codegen-arm.cc
M src/arm/jump-target-arm.cc
M src/arm/virtual-frame-arm.h
M src/arm/virtual-frame-arm.cc
M src/codegen-inl.h
M src/codegen.cc
M src/full-codegen.cc
M src/ia32/codegen-ia32.h
M src/ia32/codegen-ia32.cc
M src/ia32/full-codegen-ia32.cc
M src/ia32/jump-target-ia32.cc
M src/ia32/register-allocator-ia32.cc
M src/ia32/virtual-frame-ia32.h
M src/ia32/virtual-frame-ia32.cc
M src/jump-target-inl.h
M src/jump-target.cc
M src/register-allocator-inl.h
M src/register-allocator.cc
A src/virtual-frame-inl.h
M src/virtual-frame.cc
M src/x64/codegen-x64.h
M src/x64/codegen-x64.cc
M src/x64/fast-codegen-x64.cc
M src/x64/full-codegen-x64.cc
M src/x64/jump-target-x64.cc
M src/x64/register-allocator-x64.cc
M src/x64/virtual-frame-x64.h
M src/x64/virtual-frame-x64.cc
M tools/gyp/v8.gyp
M tools/visual_studio/v8_base.vcproj
M tools/visual_studio/v8_base_arm.vcproj
M tools/visual_studio/v8_base_x64.vcproj

[sgj...@chromium.org]

LGTM

http://codereview.chromium.org/660104/diff/26/1052
File src/arm/virtual-frame-arm.h (right):

http://codereview.chromium.org/660104/diff/26/1052#newcode349
src/arm/virtual-frame-arm.h:349: void Push(Smi* value) {
Push(Handle<Object>(value)); }
Should this be inline as well (all three platforms)?

http://codereview.chromium.org/660104

[fschn...@chromium.org]

http://codereview.chromium.org/660104/diff/26/1052
File src/arm/virtual-frame-arm.h (right):

http://codereview.chromium.org/660104/diff/26/1052#newcode349
src/arm/virtual-frame-arm.h:349: void Push(Smi* value) {
Push(Handle<Object>(value)); }

On 2010/02/26 09:14:29, Søren Gjesse wrote:
> Should this be inline as well (all three platforms)?

Done. It should be inlined already since it is defined in the .h file,
but to be consistent I moved it also to the -inl.h file.

http://codereview.chromium.org/660104