Re: Use correct timezone information on Solaris (issue 10967066)
4 views
Skip to first unread message
sven...@chromium.org
Oct 16, 2012, 2:40:11 AM10/16/12
to m...@mmalecki.com, vit...@chromium.org, yan...@chromium.org, aleksander...@gmail.com, v8-...@googlegroups.com
Some general drive-by comments: The whole time zone/DST code seems to be a
mess
for several reasons:
* tzset()/_tzset() changes the global state of the whole application, not
only v8's state, so it gives me a very uneasy feeling. Why do we use it
only on
some platforms? If we really need it somewhere, we should use it
consistently on
all platforms at the same places.
* Handling the time zone in one place and handling DST somewhere else
looks
wrong, unless the spec somehow forces us to do it this confusing way.
http://codereview.chromium.org/10967066/
mess
for several reasons:
* tzset()/_tzset() changes the global state of the whole application, not
only v8's state, so it gives me a very uneasy feeling. Why do we use it
only on
some platforms? If we really need it somewhere, we should use it
consistently on
all platforms at the same places.
* Handling the time zone in one place and handling DST somewhere else
looks
wrong, unless the spec somehow forces us to do it this confusing way.
http://codereview.chromium.org/10967066/
Reply all
Reply to author
Forward
0 new messages