Re: Issue 2368: LiveEdit crashes when new object/array literal is added (issue 11191039)

[yan...@chromium.org]

LGTM, but some suggestions for naming.


http://codereview.chromium.org/11191039/diff/11001/src/liveedit.cc
File src/liveedit.cc (right):

http://codereview.chromium.org/11191039/diff/11001/src/liveedit.cc#newcode1045
src/liveedit.cc:1045: IterateJSFunctions(*shared_info, &processor);
We usually call this kind of callback *Visitor, as in
ClearValuesVisitor. Just for consistency's sake.

http://codereview.chromium.org/11191039/diff/11001/src/liveedit.cc#newcode1079
src/liveedit.cc:1079: template<typename PROCESSOR>
I think we usually use lowercase for typename. Also, visitor :)

http://codereview.chromium.org/11191039/