ARM: VFP cleanup now that VFP2 is the baseline. (issue 14119008)

[rodolph....@gmail.com]

Reviewers: ulan, danno,

Description:
ARM: VFP cleanup now that VFP2 is the baseline.

BUG=none
TEST=none


Please review this at https://codereview.chromium.org/14119008/

SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge

Affected files:
M src/arm/code-stubs-arm.h
M src/arm/code-stubs-arm.cc
M src/arm/ic-arm.cc
M src/arm/lithium-codegen-arm.cc
M src/arm/macro-assembler-arm.h
M src/arm/macro-assembler-arm.cc
M src/arm/stub-cache-arm.cc

[ul...@chromium.org]

LGTM with nits.


https://codereview.chromium.org/14119008/diff/1/src/arm/code-stubs-arm.cc
File src/arm/code-stubs-arm.cc (right):

https://codereview.chromium.org/14119008/diff/1/src/arm/code-stubs-arm.cc#newcode1896
src/arm/code-stubs-arm.cc:1896: // Load left and right operands into d6
and d7.
Load left and right operands into d0 and d1.

https://codereview.chromium.org/14119008/diff/1/src/arm/code-stubs-arm.cc#newcode1898
src/arm/code-stubs-arm.cc:1898: __ SmiUntag(scratch1, r0);
We can use left and right instead of r1 and r0.

https://codereview.chromium.org/14119008/diff/1/src/arm/code-stubs-arm.cc#newcode1905
src/arm/code-stubs-arm.cc:1905: // Load right operand to d7 or r2/r3.
Obsolete comments here and below.

https://codereview.chromium.org/14119008/diff/1/src/arm/macro-assembler-arm.h
File src/arm/macro-assembler-arm.h (right):

https://codereview.chromium.org/14119008/diff/1/src/arm/macro-assembler-arm.h#newcode498
src/arm/macro-assembler-arm.h:498: // Convert the smi or heap number in
object to an int32 using the rules
"Converts"

https://codereview.chromium.org/14119008/diff/1/src/arm/macro-assembler-arm.h#newcode512
src/arm/macro-assembler-arm.h:512: // The value ends up either in |dst|.
"Loads the number from object into dst register."

https://codereview.chromium.org/14119008/diff/1/src/arm/macro-assembler-arm.h#newcode521
src/arm/macro-assembler-arm.h:521: // Load the number from object into
double_dst in the double format.
"Loads"

https://codereview.chromium.org/14119008/

[rodolph....@gmail.com]

https://codereview.chromium.org/14119008/diff/1/src/arm/code-stubs-arm.cc
File src/arm/code-stubs-arm.cc (right):

https://codereview.chromium.org/14119008/diff/1/src/arm/code-stubs-arm.cc#newcode1896
src/arm/code-stubs-arm.cc:1896: // Load left and right operands into d6
and d7.

On 2013/04/22 11:24:49, ulan wrote:
> Load left and right operands into d0 and d1.

Done.

https://codereview.chromium.org/14119008/diff/1/src/arm/code-stubs-arm.cc#newcode1898
src/arm/code-stubs-arm.cc:1898: __ SmiUntag(scratch1, r0);

On 2013/04/22 11:24:49, ulan wrote:
> We can use left and right instead of r1 and r0.

Done.

https://codereview.chromium.org/14119008/diff/1/src/arm/code-stubs-arm.cc#newcode1905
src/arm/code-stubs-arm.cc:1905: // Load right operand to d7 or r2/r3.

On 2013/04/22 11:24:49, ulan wrote:
> Obsolete comments here and below.

Done.

https://codereview.chromium.org/14119008/diff/1/src/arm/macro-assembler-arm.h
File src/arm/macro-assembler-arm.h (right):

https://codereview.chromium.org/14119008/diff/1/src/arm/macro-assembler-arm.h#newcode498
src/arm/macro-assembler-arm.h:498: // Convert the smi or heap number in
object to an int32 using the rules

On 2013/04/22 11:24:49, ulan wrote:
> "Converts"

Done.

https://codereview.chromium.org/14119008/diff/1/src/arm/macro-assembler-arm.h#newcode512
src/arm/macro-assembler-arm.h:512: // The value ends up either in |dst|.

On 2013/04/22 11:24:49, ulan wrote:
> "Loads the number from object into dst register."

Done.

https://codereview.chromium.org/14119008/diff/1/src/arm/macro-assembler-arm.h#newcode521
src/arm/macro-assembler-arm.h:521: // Load the number from object into
double_dst in the double format.

On 2013/04/22 11:24:49, ulan wrote:
> "Loads"

Done.

https://codereview.chromium.org/14119008/